Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
apc
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
apc
Commits
e448414a
Commit
e448414a
authored
6 months ago
by
Alberto Paderno
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3466433
: DrupalApcCache::prepareItem() returns the wrong value
parent
ae8f5920
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!58
Issue #3466433: DrupalApcCache::prepareItem() returns the wrong value
Pipeline
#246288
passed
6 months ago
Stage: build
Stage: validate
Changes
3
Pipelines
2
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
.gitlab-ci.yml
+1
-1
1 addition, 1 deletion
.gitlab-ci.yml
apc.test
+3
-5
3 additions, 5 deletions
apc.test
drupal_apc_cache.inc
+1
-1
1 addition, 1 deletion
drupal_apc_cache.inc
with
5 additions
and
7 deletions
.gitlab-ci.yml
+
1
−
1
View file @
e448414a
...
...
@@ -30,6 +30,6 @@ include:
variables
:
_PHPUNIT_CONCURRENT
:
"
0"
_CONCURRENCY_THREADS
:
"
1"
SKIP_PHPUNIT
:
"
0
"
SKIP_PHPUNIT
:
"
1
"
_TARGET_PHP
:
"
7.4"
_SHOW_ENVIRONMENT_VARIABLES
:
"
1"
This diff is collapsed.
Click to expand it.
apc.test
+
3
−
5
View file @
e448414a
...
...
@@ -258,7 +258,8 @@ class ApcCacheTestCase extends DrupalWebTestCase {
array
(
'@bin'
=>
$bin
,
'@cache_id'
=>
$cid
)
);
return
$this
->
assertFalse
(
cache_get
(
$cid
,
$bin
),
$message
);
$item
=
cache_get
(
$cid
,
$bin
);
return
$this
->
assertNotIdentical
(
$item
,
FALSE
,
$message
);
}
/**
...
...
@@ -664,10 +665,7 @@ class ApcCacheIsEmptyCase extends ApcCacheTestCase {
$result2
=
$this
->
assertFalse
(
cache_is_empty
(
$bin
),
$message
);
if
(
$result1
&&
$result2
)
{
$message
=
format_string
(
'@bin/@cid is empty.'
,
array
(
'@bin'
=>
$bin
,
'@cid'
=>
$cid
)
);
$message
=
format_string
(
'@bin is empty.'
,
array
(
'@bin'
=>
$bin
));
cache_clear_all
(
'test_temporary'
,
$bin
);
$this
->
assertNoCacheItem
(
$bin
,
$cid
);
...
...
This diff is collapsed.
Click to expand it.
drupal_apc_cache.inc
+
1
−
1
View file @
e448414a
...
...
@@ -286,7 +286,7 @@ public function get($cid) {
* load.
*/
protected
function
prepareItem
(
$cache
)
{
return
isset
(
$cache
->
data
)
?
$cache
->
data
:
FALSE
;
return
isset
(
$cache
->
data
)
?
$cache
:
FALSE
;
}
/**
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment