Issue #3515885: Add missing getTools() method to OpenAiChatMessageIterator
Open
requested to merge issue/ai_provider_openai-3515885:3515885-streaming-chat-responses into 1.1.x
2 unresolved threads
Closes #3515885 - First merge Request entirely made by Claude Code... might be a terrible idea!
Merge request reports
Activity
requested review from @Marcus_Johansson
added 1 commit
1 <?php 2 3 namespace Drupal\Tests\ai_provider_openai\Unit; 4 5 use Drupal\ai\OperationType\Chat\Tools\ChatFunction; 6 use Drupal\ai\OperationType\Chat\Tools\ChatTools; 7 use Drupal\ai_provider_openai\OpenAiChatMessageIterator; 25 * @var \Drupal\ai\OperationType\Chat\Tools\ChatTools|null 26 */ 27 protected $chatTools = NULL; 28 29 /** 30 * Constructor. 31 * 32 * @param \IteratorAggregate $iterator 33 * The iterator to wrap. 34 * @param \Drupal\ai\OperationType\Chat\Tools\ChatTools|null $chatTools 35 * Optional chat tools from the input. 36 */ 37 public function __construct(\IteratorAggregate $iterator, $chatTools = NULL) { 38 parent::__construct($iterator); 39 $this->chatTools = $chatTools; 40 } - Comment on lines +37 to +40
Adding another verbose override of the constructor may fix this warning? But I'm unsure it's the best design.
40 } 40 public function __construct(\IteratorAggregate $iterator, $chatTools) { 41 parent::__construct($iterator); 42 $this->chatTools = $chatTools; 43 } 44 45 /** 46 * Constructor. 47 * 48 * @param \IteratorAggregate $iterator 49 * The iterator to wrap. 50 */ 51 public function __construct(\IteratorAggregate $iterator) { 52 parent::__construct($iterator); 53 }
Please register or sign in to reply