Skip to content
Snippets Groups Projects

3421753: fix error on new node creation

Merged 3421753: fix error on new node creation
issue/ai_auto_reference-3421753:3421753-attempt-to-create into 1.0.x
1 unresolved thread
Merged Andrea Kostakis requested to merge issue/ai_auto_reference-3421753:3421753-attempt-to-create into 1.0.x
1 unresolved thread

Closes #3421753

Merge request reports

Merge request pipeline #96161 passed with warnings

Stage: build
Stage: validate
Stage: test

Merge request pipeline passed with warnings for 92605d73

Approval is optional
Code Quality is loading
Test summary results are being parsed
Full report

Merged by Scott EuserScott Euser 1 year ago (Feb 16, 2024 3:01pm UTC)

Merge details

  • Changes merged into 1.0.x with fbdc1768 (commits were squashed).
  • Did not delete the source branch.

Pipeline #96811 passed with warnings

Stage: build
Stage: validate
Stage: test

Pipeline passed with warnings for fbdc1768 on 1.0.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/Form/AutoReferenceApplyForm.php
135 135 }
136 136
137 137 // No sense in submit button for auto-apply case.
138 if (!$auto_apply) {
138 // Check if node id exists (in case we add a new node)
139 if (!$auto_apply && $node->id()) {
  • Scott Euser
    Scott Euser @scotteuser
    Maintainer

    Hmmm I wonder how we hit here in the first place? I guess my concern here is then:

    1. User creates a new node and wants to get tag suggestions
    2. Node does not yet have an ID, so user no longer sees a 'Save selections' submit button, user is not able to apply suggested tags

    Is this the case now with this change?

  • Andrea Kostakis
    Andrea Kostakis @andreastkdf
    Author Contributor

    I assume that when a user attempts to get tag suggestions, this first saves the node (the module's custom button is submitting the node form); hence, a node ID will be available on the next step.

    Edited by Andrea Kostakis
  • Andrea Kostakis
    Andrea Kostakis @andreastkdf
    Author Contributor

    If my assumption is wrong (re-save and then generate), the patch fixes the issue but makes the "Generate references with AI" unusable on node creation. If that's the case, I think that even without the patch, this is a broader issue, as this probably breaks the new node form? The submission form likely does not let the user save a new node in general.

    Edited by Andrea Kostakis
  • Please register or sign in to reply
  • Scott Euser merged

    merged

    • Please register or sign in to reply