Skip to content

Issue #3458482: Fixed 'TypeError: $.isFunction is not a function' by replacing...

David Suissa requested to merge issue/admin_toolbar-3458482:3458482-menu-hover-is into 3.x

https://www.drupal.org/project/admin_toolbar/issues/3458482

Fixed TypeError: $.isFunction is not a function by replacing calls to JQuery by Vanilla JS typeof.

See Gitlab Pipeline errors for D11: https://git.drupalcode.org/issue/admin_toolbar-3363604/-/jobs/2209753

Time: 03:39.102, Memory: 6.00 MB
There were 3 failures:
1) Drupal\Tests\admin_toolbar_search\FunctionalJavascript\AdminToolbarSearchTest::testToolbarSearch
TypeError: $.isFunction is not a function
    at $.fn.hoverIntent (http://localhost/web/modules/custom/admin_toolbar-3363604/js/jquery.hoverIntent.js?sh3gu7:95:15)
    at HTMLDocument.<anonymous> (http://localhost/web/modules/custom/admin_toolbar-3363604/js/admin_toolbar.hoverintent.js?sh3gu7:3:121)
    at l (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:24969)
    at c (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:25288)
/builds/issue/admin_toolbar-3363604/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:132
2) Drupal\Tests\admin_toolbar_search\FunctionalJavascript\AdminToolbarSearchTest::testNoAccess
TypeError: $.isFunction is not a function
    at $.fn.hoverIntent (http://localhost/web/modules/custom/admin_toolbar-3363604/js/jquery.hoverIntent.js?sh3gv5:95:15)
    at HTMLDocument.<anonymous> (http://localhost/web/modules/custom/admin_toolbar-3363604/js/admin_toolbar.hoverintent.js?sh3gv5:3:121)
    at l (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:24969)
    at c (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:25288)
/builds/issue/admin_toolbar-3363604/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:132
3) Drupal\Tests\admin_toolbar_search\FunctionalJavascript\AdminToolbarToolsSearchTest::testToolbarSearch
TypeError: $.isFunction is not a function
    at $.fn.hoverIntent (http://localhost/web/modules/custom/admin_toolbar-3363604/js/jquery.hoverIntent.js?sh3gvf:95:15)
    at HTMLDocument.<anonymous> (http://localhost/web/modules/custom/admin_toolbar-3363604/js/admin_toolbar.hoverintent.js?sh3gvf:3:121)
    at l (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:24969)
    at c (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:25288)
TypeError: $.isFunction is not a function
    at $.fn.hoverIntent (http://localhost/web/modules/custom/admin_toolbar-3363604/js/jquery.hoverIntent.js?sh3gvf:95:15)
    at HTMLDocument.<anonymous> (http://localhost/web/modules/custom/admin_toolbar-3363604/js/admin_toolbar.hoverintent.js?sh3gvf:3:121)
    at l (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:24969)
    at c (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:25288)
TypeError: $.isFunction is not a function
    at $.fn.hoverIntent (http://localhost/web/modules/custom/admin_toolbar-3363604/js/jquery.hoverIntent.js?sh3gvf:95:15)
    at HTMLDocument.<anonymous> (http://localhost/web/modules/custom/admin_toolbar-3363604/js/admin_toolbar.hoverintent.js?sh3gvf:3:121)
    at l (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:24969)
    at c (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:25288)
TypeError: $.isFunction is not a function
    at $.fn.hoverIntent (http://localhost/web/modules/custom/admin_toolbar-3363604/js/jquery.hoverIntent.js?sh3gvf:95:15)
    at HTMLDocument.<anonymous> (http://localhost/web/modules/custom/admin_toolbar-3363604/js/admin_toolbar.hoverintent.js?sh3gvf:3:121)
    at l (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:24969)
    at c (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:25288)
TypeError: $.isFunction is not a function
    at $.fn.hoverIntent (http://localhost/web/modules/custom/admin_toolbar-3363604/js/jquery.hoverIntent.js?sh3gvf:95:15)
    at HTMLDocument.<anonymous> (http://localhost/web/modules/custom/admin_toolbar-3363604/js/admin_toolbar.hoverintent.js?sh3gvf:3:121)
    at l (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:24969)
    at c (http://localhost/web/core/assets/vendor/jquery/jquery.min.js?v=4.0.0-beta.2:2:25288)
/builds/issue/admin_toolbar-3363604/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:132
FAILURES!
Tests: 17, Assertions: 400, Failures: 3.

Merge request reports