Resolve #3627551 "Fix gitlab jobs"

David Suissarequested to merge
issue/admin_toolbar-3627551:3627551-fix-gitlab-jobs into 3.x

https://www.drupal.org/project/admin_toolbar/issues/3627551

Fixed Gitlab validation jobs for next minor (11.5.x) and LTS build (9.5.x):

  • Next minor: 11.5.x

    • phpstan:
      • Fixed project_browser error crashing the job by bumping to the dev version instead of current "buggy" stable (2.1.5).
      • Ignored phpstan deprecation errors for 11.5 and above in ToolbarControllerin file phpstan.neon.
    • phpunit:
      • Added the IgnoreDeprecations PHP Attribute to all tests classes to prevent job from failing due to deprecation warnings.
      • Fixed AdminToolbarToolsTest test regex to be a bit more flexible and allow different attributes at different position in the generated HTML markup.

  • Previous major: 10.x

    • phpstan: Removed PHP Attribute IgnoreDeprecations in all tests classes to prevent errors due to undefined attribute.

  • LTS build: 9.5.x

    • phpunit: Fixed test AdminToolbarSearchSettingsFormTest by replacing the current method using a regex to check the response, with a more flexible way comparing array values from the decoded JSON object.

Merge request reports