resolve unsafe usage of new static() warnings

Closes #3514075

admin_toolbar_search/src/Controller/AdminToolbarSearchController.php

@@ -3,7 +3,6 @@
 namespace Drupal\admin_toolbar_search\Controller;
 
 use Drupal\Core\Controller\ControllerBase;
-use Drupal\admin_toolbar_search\SearchLinks;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\HttpFoundation\JsonResponse;
 
@@ -21,23 +20,13 @@ class AdminToolbarSearchController extends ControllerBase {
    */
   protected $links;
 
-  /**
-   * Constructs an AdminToolbarSearchController object.
-   *
-   * @param \Drupal\admin_toolbar_search\SearchLinks $links
-   *   The search links service.
-   */
-  public function __construct(SearchLinks $links) {
-    $this->links = $links;
-  }
-
   /**
    * {@inheritdoc}
    */
   public static function create(ContainerInterface $container) {
-    return new static(
-      $container->get('admin_toolbar_search.search_links')
-    );
+    $instance = parent::create($container);
+    $instance->links = $container->get('admin_toolbar_search.search_links');
+    return $instance;
   }
 
   /**