Skip to content
Snippets Groups Projects

Issue #3414174 by promo-il: Add "Bypass ad tracking" permission

Open Issue #3414174 by promo-il: Add "Bypass ad tracking" permission
3 unresolved threads
Open dlevchik requested to merge issue/ad-3414174:3414174-add-bypass-ad into 11.x
3 unresolved threads

Related to #3414174

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
78 78 */
79 79 protected UuidInterface $uuidGenerator;
80 80
81 /**
82 * The current user.
83 *
84 * @var \Drupal\Core\Session\AccountInterface
85 */
86 protected AccountInterface $currentUser;
  • 221 228 protected function trackEvent(AdInterface $ad, AccountInterface $user, array $values): ?string {
    222 229 $event_id = NULL;
    223 230
    231 if ($this->currentUser->hasPermission('bypass ad track')) {
    232 return '';
    • Not really a big fan of returning an empty string here. In my opinion it should return NULL (return;), but based on the description this should only happen, when an error occurred? This needs to be investigated further.

    • Please register or sign in to reply
  • 6 6 title: 'Administer AD settings'
    7 7 description: 'Configure and manage all advertisement settings.'
    8 8 restrict access: true
    9 bypass ad track:
    10 title: 'Bypass AD tracking'
    11 description: 'Do not track AD fot those roles'
  • Leon Röthemeyer added 4 commits

    added 4 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading