Skip to content
Snippets Groups Projects

3425915: Remove Drupal 6 migration plugins.

2 unresolved threads

Closes #3425915

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #112365 failed

Merge request pipeline failed for 240a9f96

Approval is optional
Test summary results are being parsed
Ready to merge by members who can write to the target branch.
  • The source branch is 2 commits behind the target branch.
  • 1 commit will be added to 1.9.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1401 1401
1402 /**
1403 * Removes Drupal 6 migrations.
1404 *
1405 * These cause errors, unexpected outcomes, and a performance hit. We don't
1406 * need the Drupal 6 migrations in a Drupal 7 migration framework.
1407 *
1408 * @param array[] $migrations
1409 * An associative array of migrations keyed by migration ID, the same that
1410 * is passed to hook_migration_plugins_alter() hooks.
1411 *
1412 * @see acquia_migrate_migrate_field_info_alter()
1413 */
1414 public function removeDrupal6Migrations(array &$migrations) {
1415 foreach ($migrations as $key => $migration) {
1416 if (!empty($migration['migration_tags']) && in_array('Drupal 6', $migration['migration_tags'])) {
  • Always use strict comparisons:

    Suggested change
    1416 if (!empty($migration['migration_tags']) && in_array('Drupal 6', $migration['migration_tags'])) {
    1416 if (!empty($migration['migration_tags']) && in_array('Drupal 6', $migration['migration_tags'], TRUE)) {
  • Please register or sign in to reply
  • 1399 1399 }
    1400 1400 }
    1401 1401
    1402 /**
    1403 * Removes Drupal 6 migrations.
    1404 *
    1405 * These cause errors, unexpected outcomes, and a performance hit. We don't
    1406 * need the Drupal 6 migrations in a Drupal 7 migration framework.
    1407 *
    1408 * @param array[] $migrations
    1409 * An associative array of migrations keyed by migration ID, the same that
    1410 * is passed to hook_migration_plugins_alter() hooks.
    1411 *
    1412 * @see acquia_migrate_migrate_field_info_alter()
    1413 */
    1414 public function removeDrupal6Migrations(array &$migrations) {
    • Suggested change
      1414 public function removeDrupal6Migrations(array &$migrations) {
      1414 public function removeDrupal6Migrations(array &$migrations): void {
    • Please register or sign in to reply
    Please register or sign in to reply
    Loading