Skip to content
Snippets Groups Projects
project update bot's avatar
opened merge request !2 "Automated Project Update Bot fixes" at project / acquia_cloud_backup_manager
eduardo morales alberti's avatar
eduardo morales alberti's avatar
  • 8ec751d2 · Fix credentials get from environment
eduardo morales alberti's avatar
eduardo morales alberti's avatar
  • bd8cbb0a · Fix error client not defined
eduardo morales alberti's avatar
eduardo morales alberti's avatar
  • f76be2c0 · Fix error on property not defined
eduardo morales alberti's avatar
Ricardo Sanz Ante's avatar
  • 3c6ac05f · Issue #3412542 by Eduardo Morales Alberti: Backups are deleted due ...
Ricardo Sanz Ante's avatar
accepted merge request !1 "Issue #3412542 by Eduardo Morales Alberti: Backups are deleted due a bad contion on the limit" at project / acquia_cloud_backup_manager
Ricardo Sanz Ante's avatar
approved merge request !1 "Issue #3412542 by Eduardo Morales Alberti: Backups are deleted due a bad contion on the limit" at project / acquia_cloud_backup_manager
Ricardo Sanz Ante's avatar
commented on merge request !1 "Issue #3412542 by Eduardo Morales Alberti: Backups are deleted due a bad contion on the limit" at project / acquia_cloud_backup_manager

I would use $backups_to_delete for the loop to avoid creating another variable ($count) for readability reasons. Also, let's break early:...

Ricardo Sanz Ante's avatar
commented on merge request !1 "Issue #3412542 by Eduardo Morales Alberti: Backups are deleted due a bad contion on the limit" at project / acquia_cloud_backup_manager

I would use == 0 because is clearer in the sense of 0 means no limit, and I guess negative numbers are not allowed, so only 0 would match < 1.

Ricardo Sanz Ante's avatar
commented on merge request !1 "Issue #3412542 by Eduardo Morales Alberti: Backups are deleted due a bad contion on the limit" at project / acquia_cloud_backup_manager

I would recover the variable $number_of_backups so you don't run count($back_list) twice. Not of performance reasons but for readability. Also, I w...

Ricardo Sanz Ante's avatar
commented on merge request !1 "Issue #3412542 by Eduardo Morales Alberti: Backups are deleted due a bad contion on the limit" at project / acquia_cloud_backup_manager

minus -> less

eduardo morales alberti's avatar
opened merge request !1 "Issue #3412542 by Eduardo Morales Alberti: Backups are deleted due a bad contion on the limit" at project / acquia_cloud_backup_manager
eduardo morales alberti's avatar
  • 8ab295b3 · Set the right way to clear backups
eduardo morales alberti's avatar
  • 44360331 · Set required options and set default configuration
eduardo morales alberti's avatar
  • 3591d1b6 · Order backups before delete
eduardo morales alberti's avatar