Drupal 10 & 11 compatibility
Closes #3493996
Merge request reports
Activity
added 1 commit
- 8d9d4903 - Fix constructor for acl table migration plugin
15 18 * destination_module="acl", 16 19 * ) 17 20 */ 18 class AclList extends DestinationBase implements MigrateDestinationInterface { 21 class AclList extends DestinationBase implements MigrateDestinationInterface, ContainerFactoryPluginInterface { 22 /** 23 * The database connection. 24 * 25 * @var \Drupal\Core\Database\Connection 26 */ 27 protected $connection; changed this line in version 9 of the diff
15 18 * destination_module="acl", 16 19 * ) 17 20 */ 18 class AclTable extends DestinationBase implements MigrateDestinationInterface { 21 class AclTable extends DestinationBase implements MigrateDestinationInterface, ContainerFactoryPluginInterface { 22 23 /** 24 * The database connection. 25 * 26 * @var \Drupal\Core\Database\Connection 27 */ 28 protected $connection; changed this line in version 9 of the diff
15 18 * destination_module="acl", 16 19 * ) 17 20 */ 18 class AclTable extends DestinationBase implements MigrateDestinationInterface { 21 class AclTable extends DestinationBase implements MigrateDestinationInterface, ContainerFactoryPluginInterface { -
DestinationBase is already implemented MigrateDestinationInterface, let's omit.
Edited by Nikolay Shapovalov changed this line in version 9 of the diff
1 1 { 2 2 "name": "drupal/acl", 3 "description": "Provides an access control list API. Has no features on its own.", -
Please check template at https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file
changed this line in version 12 of the diff
15 18 * destination_module="acl", 16 19 * ) 17 20 */ 18 class AclList extends DestinationBase implements MigrateDestinationInterface { 21 class AclList extends DestinationBase implements MigrateDestinationInterface, ContainerFactoryPluginInterface { -
DestinationBase is already implemented MigrateDestinationInterface, let's omit.
Edited by Nikolay Shapovalov changed this line in version 8 of the diff
-
Thanks a lot for MR.
There are too many changes out of the issue scope: DI, ContainerFactoryPluginInterface, PHPCS, Readme, Changelog fix.
It would be great to use property promotion everywhere, maybe create follow up task, and make it before next release. And Convert annotation to attributes.
Otherwise LGTM and all checks are green.
Edited by Nikolay Shapovalov added 1 commit
- 8bcb5890 - Ommit MigrateDestinationInterface since it's already implemented in DestinationBase
15 17 * destination_module="acl", 16 18 * ) 17 19 */ 18 class AclTable extends DestinationBase implements MigrateDestinationInterface { 20 class AclTable extends DestinationBase implements ContainerFactoryPluginInterface { 21 22 public function __construct( changed this line in version 12 of the diff
15 17 * destination_module="acl", 16 18 * ) 17 19 */ 18 class AclList extends DestinationBase implements MigrateDestinationInterface { 20 class AclList extends DestinationBase implements ContainerFactoryPluginInterface { 21 22 public function __construct(
