Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
ace_editor
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
ace_editor
Merge requests
!3
Issue
#3279534
: Update drupal_get_path use of deprecation in the Ace Code Editor module
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Issue
#3279534
: Update drupal_get_path use of deprecation in the Ace Code Editor module
issue/ace_editor-3279534:3279534-start-a-2.0.x
into
2.0.x
Overview
0
Commits
1
Pipelines
0
Changes
1
Merged
Rajab Natshah
requested to merge
issue/ace_editor-3279534:3279534-start-a-2.0.x
into
2.0.x
3 years ago
Overview
0
Commits
1
Pipelines
0
Changes
1
Expand
Checkpoints
Add a
2.0.x
branch
Change to
core_version_requirement: ^8.8 || ^9 || ^10
in the
ace_editor.info.yml
file
Release a
2.0.x-dev
development version
This will ease the work on further issues
Real physical testing with Drupal ~10
drupal-check on the code
Testing to ensure no regression
Full testing and approval
Automated functional testing coverage
Edited
3 years ago
by
Rajab Natshah
0
0
Merge request reports
Compare
2.0.x
version 1
81786db0
3 years ago
2.0.x (base)
and
latest version
latest version
81786db0
1 commit,
3 years ago
version 1
81786db0
1 commit,
3 years ago
1 file
+
2
−
2
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
ace_editor.module
+
2
−
2
Options
@@ -17,8 +17,8 @@ function ace_editor_lib_path() {
$paths_to_check
=
[
'/libraries/ace'
,
'/libraries/ace-builds'
,
'/'
.
d
rupal
_get_path
(
'module'
,
'ace_editor'
)
.
'/libraries
/
'
,
'/'
.
d
rupal
_get_path
(
'profile'
,
\Drupal
::
installProfile
())
.
'/libraries/ace'
,
'/'
.
\D
rupal
::
service
(
'extension.list.module'
)
->
getPath
(
'ace_editor'
)
.
'/libraries'
,
'/'
.
\D
rupal
::
service
(
'extension.list.profile'
)
->
getPath
(
\Drupal
::
installProfile
())
.
'/libraries/ace'
,
];
foreach
(
$paths_to_check
as
$path
)
{
Loading