Loading
task: #3594544 Automated Drupal 12 compatibility fixes for ace_editor 2.0.x-dev
This MR makes Ace Editor 2.0.x compatible with Drupal 12 by widening the core version constraints. Reviewed, tested, and finalized on Vardot behalf.
Changes
ace_editor.info.yml:core_version_requirement: ^10 || ^11→^10 || ^11 || ^12composer.json:drupal/core: ^10 || ^11→^10 || ^11 || ^12docs/faq.md: updated the supported-core-versions answer to include Drupal 12.
Review notes
- Drupal Rector + Upgrade Status (via the Project Update Bot) found no other deprecations; the module source uses no APIs removed in Drupal 12 (plugin annotations,
drupal_static(), and\Drupal::static calls all remain valid). - The commit was authored/attributed to follow the Git commit message standards.
- This is a constraint-only change: no PHP/JS/CSS/markup is modified, so there is no UX/UI, accessibility, performance, or security surface to change in this MR.
Testing
- Remote GitLab CI pipeline green:
webship-js-test,phpunit,phpcs,phpstan,eslint,stylelint,cspell,composer-lint,composerall pass. - Local rounds (gitlab-ci-local) green:
cspell,eslint,pages, andwebship-js-test— the functional suite ran 12 scenarios (12 passed), 76 steps (76 passed) against a freshly built Drupal site, including the accessibility scenarios.
AI policy disclosure
Per the policy on the use of AI when contributing to Drupal:
AI-Generated: Yes — Drupal Rector + Upgrade Status via the automated Project Update Bot generated the version-constraint updates. The changes were reviewed, verified, and tested manually before submission; the contributor takes full responsibility for the result.
Checkpoints
Only boxes where concrete work was performed for this MR are checked; constraint-only items with nothing to do are marked N/A.
- File an issue
- Addition/Change/Update/Fix
- Testing to ensure no regression — ran the suite locally (gitlab-ci-local) and on remote CI
- Automated unit testing coverage — N/A, no new code paths; existing Unit test still passes
- Automated functional testing coverage — N/A, no new behavior; existing BDD suite still passes
- UX/UI designer responsibilities — N/A, no UI/markup/styling change
- Readability — N/A, version-string + one doc sentence only
- Accessibility — N/A, no markup/ARIA change
- Performance — N/A, no runtime code change
- Security — N/A, no input/output/permission surface change
- Documentation — updated
docs/faq.md - Code review by maintainers
- Full testing and approval
- Credit contributors
- Review with the product owner
- Release notes snippet
- Release
Edited by Rajab Natshah