Issue #3369116: Donation page link field should be required

modules/lb_donate/config/optional/field.field.block_content.lb_donate.field_cta.yml

@@ -12,7 +12,7 @@ entity_type: block_content
 bundle: lb_donate
 label: 'Donation page link'
 description: 'This should link to a donate page with an embedded form.'
-required: false
+required: true
 translatable: true
 default_value: {  }
 default_value_callback: ''

modules/lb_donate/lb_donate.install

@@ -32,3 +32,16 @@ function lb_donate_update_9001(&$sandbox) {
     'field.field.paragraph.lb_donate_giving_amount.field_form_element_id',
   ]);
 }
+
+/**
+ * Require CTA field too.
+ */
+function lb_donate_update_9002(&$sandbox) {
+  $path = \Drupal::service('extension.list.module')->getPath('lb_donate') . '/config/optional';
+  /** @var \Drupal\config_import\ConfigImporterService $config_importer */
+  $config_importer = \Drupal::service('config_import.importer');
+  $config_importer->setDirectory($path);
+  $config_importer->importConfigs([
+    'field.field.block_content.lb_donate.field_cta',
+  ]);
+}

modules/lb_donate/lb_donate.module

@@ -56,7 +56,8 @@ function lb_donate_preprocess_block__lb_donate(&$variables){
   $variables['donate']['#items'] = [];
   $variables['donate']['#theme'] = 'item_list';
 
-  if ($variables["elements"]["content"]["field_cta"] && $donate_uri = $variables["elements"]["content"]["field_cta"]['#items']->first()->uri) {
+  if ($variables["elements"]["content"]["field_cta"] && isset($variables["elements"]["content"]["field_cta"]['#items'])) {
+    $donate_uri = $variables["elements"]["content"]["field_cta"]['#items']->first()->uri;
     $donate_link = Url::fromUri($donate_uri);
 
     // Validate and create nav from tab list.