By yanniboi: Created simplytest roles and permissions.

config/install/user.role.simplytest_manager.yml

+langcode: en
+status: true
+dependencies: {  }
+id: simplytest_manager
+label: Manager
+weight: 3
+is_admin: false
+permissions:
+  - administer submission entities
+  - create submission entities

modules/simplytest_submission/simplytest_submission.permissions.yml

+administer submission entities:
+  title: 'Administer submissions and submissions settings'
+  restrict access: true
+create submission entities:
+  title: 'Create submissions'

modules/simplytest_submission/src/SubmissionAccessControlHandler.php

@@ -22,16 +22,13 @@ class SubmissionAccessControlHandler extends EntityAccessControlHandler {
     if ($result->isNeutral()) {
       switch ($operation) {
         case 'view':
-          return AccessResult::allowedIfHasPermission($account, 'view submission entities');
+          return AccessResult::allowedIfHasPermission($account, 'administer submission entities');
 
         case 'update':
-          return AccessResult::allowedIfHasPermission($account, 'edit submission entities');
-
-        case 'manage':
-          return AccessResult::allowedIfHasPermission($account, 'manage submission entities');
+          return AccessResult::allowedIfHasPermission($account, 'administer submission entities');
 
         case 'delete':
-          return AccessResult::allowedIfHasPermission($account, 'delete submission entities');
+          return AccessResult::allowedIfHasPermission($account, 'administer submission entities');
       }
     }
     return $result;
@@ -43,7 +40,7 @@ class SubmissionAccessControlHandler extends EntityAccessControlHandler {
   protected function checkCreateAccess(AccountInterface $account, array $context, $entity_bundle = NULL) {
     $result = parent::checkCreateAccess($account, $context, $entity_bundle);
     if ($result->isNeutral()) {
-      return AccessResult::allowed();
+      return AccessResult::allowedIfHasPermission($account, 'create submission entities');
     }
     return $result;
   }

modules/simplytest_submission/src/SubmissionHtmlRouteProvider.php

@@ -64,7 +64,7 @@ class SubmissionHtmlRouteProvider extends AdminHtmlRouteProvider {
           '_entity_list' => $entity_type_id,
           '_title' => "{$entity_type->getLabel()} list",
         ])
-        ->setRequirement('_permission', 'view submission entities')
+        ->setRequirement('_permission', 'administer submission entities')
         ->setOption('_admin_route', TRUE);
 
       return $route;
@@ -145,7 +145,7 @@ class SubmissionHtmlRouteProvider extends AdminHtmlRouteProvider {
         '_controller' => '\Drupal\simplytest_submission\Controller\SimplytestSubmissionController::submissionProgress',
         '_title' => "Thank your for your submission",
       ])
-      ->setRequirement('_permission', 'create submission content');
+      ->setRequirement('_permission', 'create submission entities');
 
     $route->setOption('parameters', $parameters);
     return $route;
@@ -171,7 +171,7 @@ class SubmissionHtmlRouteProvider extends AdminHtmlRouteProvider {
         '_controller' => '\Drupal\simplytest_submission\Controller\SimplytestSubmissionController::deleteSubmissionInstance',
         '_title' => "Delete Instance",
       ])
-      ->setRequirement('_permission', 'delete submission content');
+      ->setRequirement('_permission', 'administer submission entities');
 
     $route->setOption('parameters', $parameters)
       ->setOption('_admin_route', TRUE);

simplytest.install

@@ -6,6 +6,7 @@
  */
 
 use Drupal\user\Entity\User;
+use Drupal\user\RoleInterface;
 
 /**
  * Implements hook_install().
@@ -22,6 +23,10 @@ function simplytest_install() {
   $user_settings = \Drupal::configFactory()->getEditable('user.settings');
   $user_settings->set('register', USER_REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL)->save(TRUE);
 
+  // Enable default permissions for system roles.
+  user_role_grant_permissions(RoleInterface::ANONYMOUS_ID, ['create submission entities']);
+  user_role_grant_permissions(RoleInterface::AUTHENTICATED_ID, ['create submission entities']);
+
   // Assign user 1 the "administrator" role.
   $user = User::load(1);
   $user->roles[] = 'administrator';

simplytest.links.menu.yml

@@ -2,3 +2,8 @@ simplytest.front_page:
   title: 'Home'
   route_name: '<front>'
   menu_name: main
+
+simplytest.submission_list:
+  title: 'Submissions'
+  route_name: 'entity.simplytest_submission.collection'
+  menu_name: main