Update code based on feedback

src/SearchAPI/BackendClient.php

@@ -379,38 +379,38 @@ class BackendClient implements BackendClientInterface {
     // For example the putMappings method on the OS client expects an empty
     // object but getMapping returns an empty array. Ensure float values are
     // preserved as json_encode doesn't preserve them by default.
-    $result = $this->arrayDiffAssocRecursive(
+    return $this->mappingsHaveDifferences(
       $openSearchMapping[$this->getIndexId($index)]['mappings']['properties'],
       json_decode(
         json_encode($drupalMapping['body']['properties'], JSON_PRESERVE_ZERO_FRACTION),
         TRUE
       )
     );
-    return !empty($result);
   }
 
   /**
    * Recursively diff an associative array to find differences.
+   *
+   * If any difference is found bail early.
    */
-  private function arrayDiffAssocRecursive($array1, $array2): array {
-    $difference = [];
+  private function mappingsHaveDifferences(array $array1, array $array2): bool {
     foreach ($array1 as $key => $value) {
       if (is_array($value)) {
         if (!isset($array2[$key]) || !is_array($array2[$key])) {
-          $difference[$key] = $value;
+          return TRUE;
         }
         else {
-          $newDiff = $this->arrayDiffAssocRecursive($value, $array2[$key]);
+          $newDiff = $this->mappingsHaveDifferences($value, $array2[$key]);
           if (!empty($newDiff)) {
-            $difference[$key] = $newDiff;
+            return TRUE;
           }
         }
       }
       elseif (!array_key_exists($key, $array2) || $array2[$key] !== $value) {
-        $difference[$key] = $value;
+        return TRUE;
       }
     }
-    return $difference;
+    return FALSE;
   }
 
 }