Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
search_api_opensearch-3285438
Manage
Activity
Members
Labels
Plan
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Issue forks
search_api_opensearch-3285438
Commits
49da79d6
Commit
49da79d6
authored
1 year ago
by
Andrew Hughes-Onslow
Committed by
Kim Pepper
1 year ago
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3355410
by kim.pepper: Unknown key for a VALUE_NULL in [size]
parent
da1ff60c
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Pipeline
#90081
failed
1 year ago
Stage: build
Stage: lint
Stage: test
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/SearchAPI/Query/QueryParamBuilder.php
+2
-2
2 additions, 2 deletions
src/SearchAPI/Query/QueryParamBuilder.php
tests/src/Unit/SearchAPI/Query/QueryParamBuilderTest.php
+2
-2
2 additions, 2 deletions
tests/src/Unit/SearchAPI/Query/QueryParamBuilderTest.php
with
4 additions
and
4 deletions
src/SearchAPI/Query/QueryParamBuilder.php
+
2
−
2
View file @
49da79d6
...
...
@@ -137,8 +137,8 @@ class QueryParamBuilder {
$body
=
[];
// Set the size and from parameters.
$body
[
'from'
]
=
$query
->
getOption
(
'offset'
,
self
::
DEFAULT_OFFSET
)
;
$body
[
'size'
]
=
$query
->
getOption
(
'limit'
,
self
::
DEFAULT_LIMIT
)
;
$body
[
'from'
]
=
$query
->
getOption
(
'offset'
)
??
self
::
DEFAULT_OFFSET
;
$body
[
'size'
]
=
$query
->
getOption
(
'limit'
)
??
self
::
DEFAULT_LIMIT
;
// Sort.
$sort
=
$this
->
sortBuilder
->
getSortSearchQuery
(
$query
);
...
...
This diff is collapsed.
Click to expand it.
tests/src/Unit/SearchAPI/Query/QueryParamBuilderTest.php
+
2
−
2
View file @
49da79d6
...
...
@@ -65,9 +65,9 @@ class QueryParamBuilderTest extends UnitTestCase {
->
willReturn
(
$fields
);
$query
=
$this
->
prophesize
(
QueryInterface
::
class
);
$query
->
getOption
(
'offset'
,
Argument
::
any
()
)
$query
->
getOption
(
'offset'
)
->
willReturn
(
0
);
$query
->
getOption
(
'limit'
,
Argument
::
any
()
)
$query
->
getOption
(
'limit'
)
->
willReturn
(
10
);
$query
->
getOption
(
'opensearch_exclude_source_fields'
,
Argument
::
any
())
->
willReturn
([]);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment