All references to salesforce_encrypt.client service removed
salesforce_encrypt.client service definition removed
Unused use statements removed from EncryptedRestClientInterface andRestCientInterface
Constructors removed from EncryptedRestClientInterface and RestClientInterface
Salesforce_encrypt\RestClient constructor cleaned up
Adds Json mock to salesforce_encrypt\RestClientTest
Fixes service name error in PullBase
Fixes property visibility settings in RestClient so child salesforce_encrypt\RestClient may
inherit them.

Normalizes RestClientInterface injection in DeleteHandler and QueueHandler
All unit tests passing

# Conflicts:
#	modules/salesforce_mapping/src/Form/MappedObjectForm.php
#	modules/salesforce_pull/src/DeleteHandler.php
#	modules/salesforce_pull/src/Plugin/QueueWorker/PullBase.php
#	modules/salesforce_pull/src/QueueHandler.php
#	src/Form/AuthorizeForm.php
#	src/Rest/RestClient.php
#	src/Rest/RestClientInterface.php

and SaleforceControllerTest so all units tests pass.

RestClientTest::initClient

Makes linter pass on RestClientTest

Makes linter pass on MappedObject
Adds missing SalesforcePushParamsEvent use statement to MappedObject

Completes intelligent Drupal entity ID upsert code in PullBase

If the SF API cannot be reached while trying to save the entity ID in SF, the queue processing is
halted and the current queue item and remaining queue items are kept to process on a future pass.
A check has been added on PullBase::updateEntity() to send the Entity ID to SF if none exists and
the ID is configured to sync.
Adds PullException to facilitate throwing expected Exception up to Cron to tell Cron to suspend
queue processing but keep current and remaining queue items.

Add check on results return in QueueHandler to avoid error of calling $results->records on non-
existant object.
Updates RestClient::apiCall to throw RestExceptions in all error cases
Updates PullBase to detect RestExceptions from RestClient.

Includes test code in PullBase to force exceptions to test new logic. SuspendQueueException may
not be the proper Queue Exception to throw - it seems to delete/‘release’ the problematic item when
it should be kept so it can be processed fully.

Adds new state value to force an update in PullBase::updateEntity

Adds first pass at making pushing upset IDs to SF optional/configurable. It only pushes if the
mapping has a defined upsert key.

# Conflicts:
#	modules/salesforce_mapping/src/Entity/MappedObject.php
#	modules/salesforce_mapping/src/Form/MappedObjectForm.php
#	modules/salesforce_mapping/src/Plugin/SalesforceMappingField/RelatedProperties.php
#	modules/salesforce_mapping/tests/src/Unit/MappedObjectTest.php
#	modules/salesforce_push/salesforce_push.module
#	modules/salesforce_push/src/PushQueue.php
#	src/Form/AuthorizeForm.php

- tweak to DeleteHandler timeframes to cover a gap in coverage, and to cover earlier start dates for first cron run
- update sf push to respect salesforce_pull flag
- convert Rest push queue processor events to "OpEvent"s, rather than ParamsEvents

- reset mapped object revision log message on push success
- add "push_success" and "push_fail" subscribers in example module

MappedObjectListTest

Approved-by: Aaron Bauman

* 8.x-3.x: (36 commits)
  Merged RestClient-tests into 8.x-3.x: test coverage for RestClient methods
  Fixes non-existent callback URL in SF Auth process
  fixes $$this typo; adds getRequestTime wrapper for testability
  alpha-sort use statements across a few classes
  Adds initial coverage for mappedobject::pull
  Fixes PullBase and PullBaseTest Cleans up PullBase
  Cleans up all salesforce_pull tests
  RestClientTest - basic setup and stubs
  Almost have PullBaseTest working
  remove unneccesary mocks and wrappers
  initial unit test coverage for MappedObject
  Fixes various issues causing unit tests to fail
  PullBase not in a good state, still needs major attention, but moving to lower-level tests for entities before proceeding there MappedObjectTest setUp method implemented; stubs for push, pushDelete, and pull tests
  Cleans up SalesForceMappingInterface
  interim commit
  still plugging away on tests
  end of day commit. not working
  End of week commit Adds DeleteHandlerTest (not quite working yet) Removes injected Url object in RestClient. There is no @url service in core.services.yml and we’re not supposed to use UrlGenerator. Since Url is only used once in RestClient::getAuthCallbackUrl(), Url is used directly and that method can be easily mocked under test. Cleans up salesforce_pull_cron() Cleans up DeleteHandler’s use statements Adds Request object to DeleteHandler’s constructor to handle REQUEST_TIME server global Adds boolean returns to DeleteHandler methods for unit testing purposes Fixes camel casing in MappedObjectStorage::loadBySfid() call in DeleteHandler Converts try/catch pairs in DeleteHandler to non-exception based conditional logic to make logic testable Cleans up PullBase’s use statements Adds event dispatcher service to PullBase’s constructor Removes some property reference discrepancies in PullBase Removes unnecessary code from PullBaseTest Removes unnecessary code from QueueHandlerTest Adds back in missing properties in a loadByProperties call in salesforce_push.module Adds logger.factory service to PushQueue’s service definition in salesforce_push.services.yml Changes logger service injection in PushQueue’s constructor to logger.factory service (there is no logger service defined in core.services.yml) Fixes all logger service references in PushQueue Cleans up SalesforcePushQueueProcessor/Rest’s use statements Removes EntityManager service injection in SalesforcePushQueueProcessor/Rest’s constructor in favor of already existing EntityTypeManager service
  "continue" should have been "return"
  Cleans up PullBaseTest::testProcessItemCreate()
  ...

Conflicts:
	modules/salesforce_mapping/src/Entity/MappedObject.php
	modules/salesforce_push/src/Plugin/SalesforcePushQueueProcessor/Rest.php