Switch to using DeveloperName instead of id for recordtype filtering. #14260720.

modules/salesforce_mapping/src/Entity/SalesforceMapping.php

@@ -703,7 +703,7 @@ class SalesforceMapping extends ConfigEntityBase implements SalesforceMappingInt
       }
       if (!empty($record_types)) {
         $record_types_list = implode("', '", $record_types);
-        $soql->conditions[] = ["RecordType.Id IN ('" . $record_types_list . "')"];
+        $soql->conditions[] = ["RecordType.DeveloperName IN ('" . $record_types_list . "')"];
       }
     }
     $soql->order[$this->getPullTriggerDate()] = 'ASC';

modules/salesforce_mapping_ui/src/Form/SalesforceMappingFormCrudBase.php

@@ -225,7 +225,7 @@ abstract class SalesforceMappingFormCrudBase extends SalesforceMappingFormBase {
       $record_type_options = [];
       if ($salesforce_object && !empty($salesforce_object->recordTypeInfos)) {
         foreach ($salesforce_object->recordTypeInfos as $record_type_info) {
-          $record_type_options[$record_type_info['recordTypeId']] = $record_type_info['name'];
+          $record_type_options[$record_type_info['developerName']] = $record_type_info['name'];
         }
       }
       $form['pull']['pull_record_type_filter'] = [