Issue #3365350 by tim.plunkett, chrisfromredfin: Tests are broken since...

Issue #3365350 by tim.plunkett, chrisfromredfin: Tests are broken since disabling "add new module" route

config/install/project_browser.admin_settings.yml

 enabled_sources:
   - drupalorg_mockapi
 allow_ui_install: false
+disable_add_new_module: true

drupalci.yml

@@ -8,6 +8,10 @@ build:
       # Run code quality checks.
       container_command.commit-checks:
         commands:
+          # Install rsync.
+          - DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y rsync
+          # Update to latest Composer.
+          - composer self-update
           # @todo Replace in favor of commit-code-check.sh once https://www.drupal.org/project/drupal/issues/3314100 lands.
           - modules/contrib/project_browser/scripts/commit-code-check.sh --drupalci
         halt-on-fail: true

project_browser.module

@@ -43,7 +43,7 @@ function _project_browser_populate_from_fixture($truncate_first = TRUE) {
  * Implements hook_menu_links_discovered_alter().
  */
 function project_browser_menu_links_discovered_alter(&$links) {
-  if (\Drupal::config('project_browser.admin_settings')->get('disable_add_new_module') ?? TRUE) {
+  if (\Drupal::config('project_browser.admin_settings')->get('disable_add_new_module')) {
     // Remove link from Admin toolbar module.
     unset($links['admin_toolbar_tools.extra_links:update.module_install']);
   }

project_browser.post_update.php

+<?php
+
+/**
+ * @file
+ * Post update functions for Project Browser.
+ */
+
+/**
+ * Set a default value for disable_add_new_module setting.
+ */
+function project_browser_post_update_default_for_disable_add_new_module(&$sandbox) {
+  \Drupal::configFactory()
+    ->getEditable('project_browser.admin_settings')
+    ->set('disable_add_new_module', TRUE)
+    ->save(TRUE);
+}

src/EventSubscriber/DisableAddNewModuleRouteSubscriber.php

@@ -12,20 +12,12 @@ use Symfony\Component\Routing\RouteCollection;
 class DisableAddNewModuleRouteSubscriber extends RouteSubscriberBase {
 
   /**
-   * The config factory interface.
+   * DisableAddNewModuleRouteSubscriber constructor.
    *
-   * @var \Drupal\Core\Config\ConfigFactoryInterface
-   */
-  protected $configFactory;
-
-  /**
-   * EnabledSourceHandler constructor.
-   *
-   * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
+   * @param \Drupal\Core\Config\ConfigFactoryInterface $configFactory
    *   The config factory.
    */
-  public function __construct(ConfigFactoryInterface $config_factory) {
-    $this->configFactory = $config_factory;
+  public function __construct(protected ConfigFactoryInterface $configFactory) {
   }
 
   /**
@@ -33,8 +25,8 @@ class DisableAddNewModuleRouteSubscriber extends RouteSubscriberBase {
    */
   protected function alterRoutes(RouteCollection $collection) {
     $config = $this->configFactory->get('project_browser.admin_settings');
-    if ($config->get('disable_add_new_module') ?? TRUE) {
-      $collection->get('update.module_install')->setRequirement('_access', 'FALSE');
+    if ($config->get('disable_add_new_module') && $route = $collection->get('update.module_install')) {
+      $route->setRequirement('_access', 'FALSE');
     }
   }
 

src/Form/SettingsForm.php

@@ -157,7 +157,7 @@ class SettingsForm extends ConfigFormBase {
     $form['disable_add_new_module'] = [
       '#type' => 'checkbox',
       '#title' => $this->t('Disable "Add new module" page'),
-      '#default_value' => $config->get('disable_add_new_module') ?? TRUE,
+      '#default_value' => $config->get('disable_add_new_module'),
       '#description' => $this->t('Removes access to the Drupal page that allows .tar modules to be installed, which does now use composer, so is strongly discouraged when using Project Browser.'),
     ];
 
@@ -283,7 +283,7 @@ class SettingsForm extends ConfigFormBase {
    */
   public function submitForm(array &$form, FormStateInterface $form_state) {
     $settings = $this->config('project_browser.admin_settings');
-    $disable_old = $settings->get('disable_add_new_module') ?? TRUE;
+    $disable_old = $settings->get('disable_add_new_module');
     $disable_new = $form_state->getValue('disable_add_new_module');
     $all_plugins = $form_state->getValue('enabled_sources');
     $enabled_plugins = array_filter($all_plugins, fn($source) => $source['status'] === 'enabled');