Skip to content
Snippets Groups Projects
Commit 20ffba36 authored by utkarsh_33's avatar utkarsh_33 Committed by Chris Wells
Browse files

Issue #3476807 by utkarsh_33, chrisfromredfin, leslieg, rkoller, narendrar,...

Issue #3476807 by utkarsh_33, chrisfromredfin, leslieg, rkoller, narendrar, bsnodgrass, lostcarpark, lavanyatalwar, pameeela, tonypaulbarker: Decide on naming Queue/Dequeue button text
parent b3725372
No related branches found
No related tags found
No related merge requests found
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
......@@ -52,13 +52,13 @@
{#if PACKAGE_MANAGER.available && PACKAGE_MANAGER.errors.length === 0}
{#if isQueued(project.id)}
<ProjectButtonBase click={() => handleDequeueClick(project.id)}>
{Drupal.t('Dequeue')}<span class="visually-hidden"
{Drupal.t('Deselect')}<span class="visually-hidden"
>{project.title}</span
>
</ProjectButtonBase>
{:else}
<ProjectButtonBase click={() => handleAddToQueueClick(project)}>
{Drupal.t('Queue')}<span class="visually-hidden"
{Drupal.t('Select')}<span class="visually-hidden"
>{project.title}</span
>
</ProjectButtonBase>
......
......@@ -75,7 +75,7 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
$cream_cheese_module_selector = '#project-browser .pb-layout__main ul > li:nth-child(1)';
$download_button = $assert_session->waitForElementVisible('css', "$cream_cheese_module_selector button.project__action_button");
$this->assertNotEmpty($download_button);
$this->assertSame('Queue Cream cheese on a bagel', $download_button->getText());
$this->assertSame('Select Cream cheese on a bagel', $download_button->getText());
$download_button->click();
$this->assertNotEmpty($assert_session->waitForButton('Install selected projects'));
$page->pressButton('Install selected projects');
......@@ -103,7 +103,7 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
$pinky_brain_selector = '#project-browser .pb-layout__main ul > li:nth-child(2)';
$action_button = $assert_session->waitForElementVisible('css', "$pinky_brain_selector button.project__action_button");
$this->assertNotEmpty($action_button);
$this->assertSame('Queue Pinky and the Brain', $action_button->getText());
$this->assertSame('Select Pinky and the Brain', $action_button->getText());
$action_button->click();
$this->assertNotEmpty($assert_session->waitForButton('Install selected projects'));
$page->pressButton('Install selected projects');
......@@ -140,7 +140,7 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
// Apply a recipe that ships with core.
$card = $assert_session->waitForElementVisible('css', '.pb-project:contains("Image media type")');
$this->assertNotEmpty($card);
$assert_session->buttonExists('Queue', $card)->press();
$assert_session->buttonExists('Select', $card)->press();
$this->assertNotEmpty($assert_session->waitForButton('Install selected projects'));
$page->pressButton('Install selected projects');
$recipe_applied = $card->waitFor(30, function (NodeElement $card): bool {
......@@ -168,7 +168,7 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
$cream_cheese_module_selector = '#project-browser .pb-layout__main ul > li:nth-child(1)';
$download_button = $assert_session->waitForElementVisible('css', "$cream_cheese_module_selector button.project__action_button");
$this->assertNotEmpty($download_button);
$this->assertSame('Queue Cream cheese on a bagel', $download_button->getText());
$this->assertSame('Select Cream cheese on a bagel', $download_button->getText());
$this->drupalGet('/admin/config/development/project_browser');
$page->find('css', '#edit-allow-ui-install')->click();
$assert_session->checkboxNotChecked('edit-allow-ui-install');
......@@ -303,7 +303,7 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
$cream_cheese_module_selector = '#project-browser .pb-layout__main ul > li:nth-child(1)';
$download_button = $assert_session->waitForElementVisible('css', "$cream_cheese_module_selector button.project__action_button");
$this->assertNotEmpty($download_button);
$this->assertSame('Queue Cream cheese on a bagel', $download_button->getText());
$this->assertSame('Select Cream cheese on a bagel', $download_button->getText());
$download_button->click();
$this->assertNotEmpty($assert_session->waitForButton('Install selected projects'));
$page->pressButton('Install selected projects');
......@@ -358,9 +358,9 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
$cream_cheese_module_selector = '#project-browser .pb-layout__main ul > li:nth-child(1)';
$queue_button1 = $assert_session->waitForElementVisible('css', "$cream_cheese_module_selector button.project__action_button");
$this->assertNotEmpty($queue_button1);
$this->assertSame('Queue Cream cheese on a bagel', $queue_button1->getText());
$this->assertSame('Select Cream cheese on a bagel', $queue_button1->getText());
$queue_button1->click();
$was_queued = $queue_button1->waitFor(10, fn ($button) => $button->getText() === 'Dequeue Cream cheese on a bagel');
$was_queued = $queue_button1->waitFor(10, fn ($button) => $button->getText() === 'Deselect Cream cheese on a bagel');
$this->assertTrue($was_queued);
$this->assertNotEmpty($assert_session->waitForButton('Install selected projects'));
......@@ -368,10 +368,10 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
$kangaroo_module_selector = '#project-browser .pb-layout__main ul > li:nth-child(4)';
$queue_button2 = $assert_session->waitForElementVisible('css', "$kangaroo_module_selector button.project__action_button");
$this->assertNotEmpty($queue_button2);
$this->assertSame('Queue Kangaroo', $queue_button2->getText());
$this->assertSame('Select Kangaroo', $queue_button2->getText());
$queue_button2->click();
$was_dequeued = $queue_button2->waitFor(10, function ($button) {
return $button->getText() === 'Dequeue Kangaroo';
return $button->getText() === 'Deselect Kangaroo';
});
$this->assertTrue($was_dequeued);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment