Skip to content

PHPCS Updates for the D10 compatibility branch

Chris Green requested to merge PHPCS-updates into 3297262-automated-drupal-10

FILE: ...l/form_mode_manager/tests/src/Functional/FormModeManagerBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 105 | ERROR   | The @var tag must be the first tag in a member
     |         | variable comment
     |         | (Drupal.Commenting.VariableComment.VarOrder)
 171 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
     |         | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
 180 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
     |         | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
----------------------------------------------------------------------


FILE: ...form_mode_manager/tests/src/Functional/FormModeManagerUiTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 256 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
     |         | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
 340 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
     |         | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
 361 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
     |         | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
----------------------------------------------------------------------


FILE: ...m_mode_manager/tests/src/Functional/FormModeManagerRouteTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
  29 | WARNING | Unused variable $node_type_test_page.
     |         | (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
 239 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
     |         | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
----------------------------------------------------------------------


FILE: ...s/form_mode_theme_switcher/src/Theme/FormModeThemeNegociator.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
  6 | ERROR   | [x] Use statements should be sorted alphabetically.
    |         |     The first wrong one is
    |         |     Drupal\Core\Config\ConfigFactoryInterface.
    |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
 13 | WARNING | [ ] The class short comment should describe what the
    |         |     class does and not simply repeat the class
    |         |     name (Drupal.Commenting.ClassComment.Short)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...usr/local/form_mode_manager/src/Form/FormModeManagerFormBase.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
  10 | ERROR   | [x] Use statements should be sorted alphabetically.
     |         |     The first wrong one is
     |         |     Drupal\Core\Form\ConfigFormBase.
     |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
  19 | ERROR   | [ ] Unnecessarily gendered language in a comment
     |         |     (Drupal.Commenting.GenderNeutralComment.GenderNeutral)
 139 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
     |         |     (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...mode_manager/src/Plugin/Derivative/FormModeManagerLocalTasks.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The
   |       |     first wrong one is
   |       |     Drupal\Core\StringTranslation\StringTranslationTrait.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...usr/local/form_mode_manager/src/Plugin/EntityRoutingMap/Term.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 22 | WARNING | The class short comment should describe what the
    |         | class does and not simply repeat the class name
    |         | (Drupal.Commenting.ClassComment.Short)
----------------------------------------------------------------------


FILE: ...usr/local/form_mode_manager/src/Plugin/EntityRoutingMap/User.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 22 | WARNING | The class short comment should describe what the
    |         | class does and not simply repeat the class name
    |         | (Drupal.Commenting.ClassComment.Short)
----------------------------------------------------------------------


FILE: ...usr/local/form_mode_manager/src/Plugin/EntityRoutingMap/Node.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 22 | WARNING | The class short comment should describe what the
    |         | class does and not simply repeat the class name
    |         | (Drupal.Commenting.ClassComment.Short)
----------------------------------------------------------------------


FILE: ...l/form_mode_manager/src/Plugin/EntityRoutingMap/BlockContent.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 25 | WARNING | The class short comment should describe what the
    |         | class does and not simply repeat the class name
    |         | (Drupal.Commenting.ClassComment.Short)
----------------------------------------------------------------------


FILE: ...r/local/form_mode_manager/src/EntityFormModeManagerInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class
   |         | does and not simply repeat the class name
   |         | (Drupal.Commenting.ClassComment.Short)
----------------------------------------------------------------------


FILE: ..._mode_manager/src/Controller/FormModeManagerEntityController.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 17 | ERROR | [x] Use statements should be sorted alphabetically. The
    |       |     first wrong one is
    |       |     Drupal\form_mode_manager\EntityRoutingMapManager.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /usr/local/form_mode_manager/src/EntityRoutingMapBase.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  7 | ERROR | [x] Use statements should be sorted alphabetically. The
    |       |     first wrong one is
    |       |     Drupal\Core\Plugin\ContainerFactoryPluginInterface.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
 15 | ERROR | [ ] Unnecessarily gendered language in a comment
    |       |     (Drupal.Commenting.GenderNeutralComment.GenderNeutral)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /usr/local/form_mode_manager/src/FormModeManagerInterface.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
   9 | WARNING | The class short comment should describe what the
     |         | class does and not simply repeat the class name
     |         | (Drupal.Commenting.ClassComment.Short)
 198 | ERROR   | Unnecessarily gendered language in a comment
     |         | (Drupal.Commenting.GenderNeutralComment.GenderNeutral)
----------------------------------------------------------------------


FILE: /usr/local/form_mode_manager/src/EntityRoutingMapInterface.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The
   |       |     first wrong one is
   |       |     Drupal\Component\Plugin\ConfigurableInterface.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ger/src/Routing/EventSubscriber/EnhanceEntityRouteSubscriber.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The
   |       |     first wrong one is
   |       |     Drupal\form_mode_manager\EntityRoutingMapManager.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...mode_manager/src/Routing/EventSubscriber/FormModesSubscriber.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The
    |       |     first wrong one is
    |       |     Drupal\form_mode_manager\EntityRoutingMapManager.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /usr/local/form_mode_manager/src/MenuLinksInfo.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 73 | ERROR | Long array syntax must not be used in doc comment code
    |       | annotations
    |       | (Drupal.Commenting.DocCommentLongArraySyntax.DocLongArray)
----------------------------------------------------------------------

Time: 822ms; Memory: 14MB

Merge request reports