Issue #3126196 by chr.fritsch: Tests are failing on D9

modules/facets_rest/tests/rest_view/rest_view.info.yml

 name: 'Rest view'
 type: module
 description: 'Provides a Search API + rest dependency to execute tests.'
-package: 'Search'
-core: 8.x
+package: 'Testing'
 hidden: true
 dependencies:
   - drupal:rest

modules/facets_summary/tests/src/Functional/HierarchicalFacetIntegrationTest.php

@@ -5,9 +5,9 @@ namespace Drupal\Tests\facets_summary\Functional;
 use Drupal\Core\Language\LanguageInterface;
 use Drupal\search_api\Item\Field;
 use Drupal\taxonomy\Entity\Term;
-use Drupal\Tests\taxonomy\Functional\TaxonomyTestTrait;
 use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
 use Drupal\Tests\facets\Functional\FacetsTestBase;
+use Drupal\Tests\taxonomy\Traits\TaxonomyTestTrait;
 
 /**
  * Tests the hierarchical facets implementation.

modules/facets_summary/tests/src/Functional/Rest/FacetSummaryResourceTestBase.php

@@ -25,6 +25,11 @@ abstract class FacetSummaryResourceTestBase extends EntityResourceTestBase {
    */
   protected static $labelFieldName = 'name';
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'stark';
+
   /**
    * {@inheritdoc}
    */

tests/facets_custom_widget/facets_custom_widget.info.yml

 name: 'Facets custom widget'
 type: module
 description: 'Facets custom widget'
-package: 'Search'
-core_version_requirement: ^8.8 || ^9
+package: 'Testing'
 hidden: true

tests/facets_events_test/facets_events_test.info.yml

 name: 'Facets events test'
 type: module
 description: 'Facets events test'
-package: 'Search'
-core_version_requirement: ^8.8 || ^9
+package: 'Testing'
 hidden: true

tests/facets_query_processor/facets_query_processor.info.yml

 name: 'Facets query processor'
 type: module
 description: 'Facets query processor'
-package: 'Search'
-core_version_requirement: ^8.8 || ^9
+package: 'Testing'
 hidden: true

tests/facets_search_api_dependency/facets_search_api_dependency.info.yml

 name: 'Facets Search API dependecy'
 type: module
 description: 'Provides a Search API dependecy.'
-package: 'Search'
-core_version_requirement: ^8.8 || ^9
+package: 'Testing'
 hidden: true
 dependencies:
   - search_api:search_api

tests/src/Functional/BreadcrumbIntegrationTest.php

@@ -110,7 +110,7 @@ class BreadcrumbIntegrationTest extends FacetsTestBase {
     $this->drupalGet('search-api-test-fulltext', ['query' => $initial_query]);
     $this->clickLink('item');
     $breadcrumb = $this->getSession()->getPage()->find('css', '.breadcrumb');
-    $this->assertTrue(strpos($breadcrumb->getText(), 'Type'));
+    $this->assertNotFalse(strpos($breadcrumb->getText(), 'Type'));
   }
 
   /**

tests/src/Functional/LanguageIntegrationTest.php

@@ -83,7 +83,7 @@ class LanguageIntegrationTest extends FacetsTestBase {
     $this->clickLink('item');
 
     // Check that the language code is still in the url.
-    $this->assertTrue(strpos($this->getUrl(), 'xx-lolspeak/'), 'Found the language code in the url');
+    $this->assertNotFalse(strpos($this->getUrl(), 'xx-lolspeak/'), 'Found the language code in the url');
     $this->assertSession()->statusCodeEquals(200);
     $this->assertSession()->pageTextContains('item');
     $this->assertSession()->pageTextContains('article');

tests/src/Functional/Rest/FacetResourceTestBase.php

@@ -25,6 +25,11 @@ abstract class FacetResourceTestBase extends EntityResourceTestBase {
    */
   protected static $labelFieldName = 'name';
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'stark';
+
   /**
    * {@inheritdoc}
    */

tests/src/Functional/Rest/FacetSourceResourceTestBase.php

@@ -25,6 +25,11 @@ abstract class FacetSourceResourceTestBase extends EntityResourceTestBase {
    */
   protected static $labelFieldName = 'name';
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'stark';
+
   /**
    * {@inheritdoc}
    */

tests/src/Functional/TestHelperTrait.php

@@ -65,7 +65,7 @@ trait TestHelperTrait {
     foreach ($this->blocks as $block) {
       $xpath = $this->xpath('//div[@id = :id]/div[@class="facet-empty"]', [':id' => 'block-' . $block->id()]);
       if (!$xpath) {
-        $this->assertFalse($xpath);
+        $this->assertEmpty($xpath);
       }
       else {
         $this->assertTrue($this->xpath('//div[@id = :id]/div[@class="facet-empty"]', [':id' => 'block-' . $block->id()]));

tests/src/Functional/UrlIntegrationTest.php

@@ -199,7 +199,7 @@ class UrlIntegrationTest extends FacetsTestBase {
     foreach ($content_types as $content_type) {
       $this->drupalGet('search-api-test-fulltext');
       $this->clickLink('2');
-      $this->assertTrue(strpos($this->getUrl(), 'page=1'));
+      $this->assertNotFalse(strpos($this->getUrl(), 'page=1'));
       $this->clickLink($content_type);
       $this->assertFalse(strpos($this->getUrl(), 'page=1'));
     }