Issue #3444745 by fjgarlin, plopesc, m4olivei: Navigation Top Bar hides entity...

Issue #3444745 by fjgarlin, plopesc, m4olivei: Navigation Top Bar hides entity local tasks even if the user has no access to the bar

core/modules/navigation/src/Hook/NavigationHooks.php

@@ -10,6 +10,7 @@
 use Drupal\navigation\NavigationRenderer;
 use Drupal\Core\Routing\RouteMatchInterface;
 use Drupal\Core\Hook\Attribute\Hook;
+use Drupal\navigation\TopBarItemManagerInterface;
 
 /**
  * Hook implementations for navigation.
@@ -120,7 +121,11 @@ public function menuLinksDiscoveredAlter(&$links): void {
   public function blockBuildLocalTasksBlockAlter(array &$build, BlockPluginInterface $block): void {
     $navigation_renderer = \Drupal::service('navigation.renderer');
     assert($navigation_renderer instanceof NavigationRenderer);
-    $navigation_renderer->removeLocalTasks($build, $block);
+    if (\Drupal::currentUser()->hasPermission('access navigation') &&
+      array_key_exists('page_actions', \Drupal::service(TopBarItemManagerInterface::class)->getDefinitions())
+    ) {
+      $navigation_renderer->removeLocalTasks($build, $block);
+    }
   }
 
   /**

core/modules/navigation/tests/src/Functional/NavigationTopBarTest.php

@@ -114,6 +114,15 @@ public function testTopBarVisibility(): void {
       $this->assertSession()->elementTextEquals('xpath', "//div[contains(@class, 'top-bar__content')]/div[contains(@class, 'top-bar__actions')]/button/span", 'More actions');
       $this->assertSession()->elementNotExists('xpath', '//div[@id="block-tabs"]');
     }
+
+    // Regular tabs are visible for user that cannot access to navigation.
+    $this->drupalLogin($this->drupalCreateUser([
+      'bypass node access',
+    ]));
+
+    $this->drupalGet($this->node->toUrl());
+    $this->assertSession()->elementNotExists('xpath', "//div[contains(@class, 'top-bar__content')]/div[contains(@class, 'top-bar__actions')]/button/span");
+    $this->assertSession()->elementExists('xpath', '//div[@id="block-tabs"]');
   }
 
 }