Issue #3261652 by larowlan, smustgrave, quietone, Spokje, paulocs: Deprecate...

Issue #3261652 by larowlan, smustgrave, quietone, Spokje, paulocs: Deprecate Forum module in Drupal 10

core/modules/forum/forum.info.yml

@@ -10,3 +10,5 @@ dependencies:
 package: Core
 version: VERSION
 configure: forum.overview
+lifecycle: deprecated
+lifecycle_link: "https://www.drupal.org/node/3223395#s-forum"

core/modules/forum/tests/src/Functional/ForumBlockTest.php

@@ -11,6 +11,7 @@
  * Tests the forum blocks.
  *
  * @group forum
+ * @group legacy
  */
 class ForumBlockTest extends BrowserTestBase {
 

core/modules/forum/tests/src/Functional/ForumIndexTest.php

@@ -8,6 +8,7 @@
  * Tests the forum index listing.
  *
  * @group forum
+ * @group legacy
  */
 class ForumIndexTest extends BrowserTestBase {
 

core/modules/forum/tests/src/Functional/ForumNodeAccessTest.php

@@ -9,6 +9,7 @@
  * Tests forum block view for private node access.
  *
  * @group forum
+ * @group legacy
  */
 class ForumNodeAccessTest extends BrowserTestBase {
 

core/modules/forum/tests/src/Functional/ForumTermAccessTest.php

@@ -9,6 +9,7 @@
  * Tests forum taxonomy terms for access.
  *
  * @group forum
+ * @group legacy
  */
 class ForumTermAccessTest extends BrowserTestBase {
 

core/modules/forum/tests/src/Functional/ForumTest.php

@@ -17,6 +17,7 @@
  * consistency in the database.
  *
  * @group forum
+ * @group legacy
  * @group #slow
  */
 class ForumTest extends BrowserTestBase {

core/modules/forum/tests/src/Functional/ForumUninstallTest.php

@@ -14,6 +14,7 @@
  * Tests forum module uninstallation.
  *
  * @group forum
+ * @group legacy
  * @group #slow
  */
 class ForumUninstallTest extends BrowserTestBase {
@@ -133,6 +134,7 @@ public function testForumUninstallWithField() {
     // Double check everything by reinstalling the forum module again.
     $this->drupalGet('admin/modules');
     $this->submitForm(['modules[forum][enable]' => 1], 'Install');
+    $this->submitForm([], 'Continue');
     $this->assertSession()->pageTextContains('Module Forum has been installed.');
   }
 

core/modules/forum/tests/src/Functional/GenericTest.php

@@ -8,6 +8,7 @@
  * Generic module test for forum.
  *
  * @group forum
+ * @group legacy
  */
 class GenericTest extends GenericModuleTestBase {
 

core/modules/forum/tests/src/Functional/Module/DependencyTest.php

@@ -8,6 +8,7 @@
  * Enable module without dependency enabled.
  *
  * @group form
+ * @group legacy
  */
 class DependencyTest extends ModuleTestBase {
 

core/modules/forum/tests/src/Functional/NodeAccessPagerTest.php

@@ -8,6 +8,7 @@
  * Tests access controlled node views have the right amount of comment pages.
  *
  * @group form
+ * @group legacy
  */
 class NodeAccessPagerTest extends BrowserTestBase {
 

core/modules/forum/tests/src/Functional/UrlAlterFunctionalTest.php

@@ -10,6 +10,7 @@
  * Tests altering the inbound path and the outbound path.
  *
  * @group form
+ * @group legacy
  */
 class UrlAlterFunctionalTest extends BrowserTestBase {
 

core/modules/forum/tests/src/Functional/Views/ForumIntegrationTest.php

@@ -10,6 +10,7 @@
  * Tests the forum integration into views.
  *
  * @group forum
+ * @group legacy
  */
 class ForumIntegrationTest extends ViewTestBase {
 

core/modules/forum/tests/src/Functional/migrate_drupal/d6/NoMultilingualReviewPageTest.php

@@ -8,6 +8,7 @@
  * Tests migrate upgrade review page.
  *
  * @group forum
+ * @group legacy
  */
 class NoMultilingualReviewPageTest extends NoMultilingualReviewPageTestBase {
 

core/modules/forum/tests/src/Functional/migrate_drupal/d6/Upgrade6Test.php

@@ -11,6 +11,7 @@
  *
  * @group forum
  * @group #slow
+ * @group legacy
  */
 class Upgrade6Test extends MigrateUpgradeExecuteTestBase {
 

core/modules/forum/tests/src/Functional/migrate_drupal/d7/NoMultilingualReviewPageTest.php

@@ -10,6 +10,7 @@
  * The test method is provided by the MigrateUpgradeTestBase class.
  *
  * @group forum
+ * @group legacy
  */
 class NoMultilingualReviewPageTest extends NoMultilingualReviewPageTestBase {
 

core/modules/forum/tests/src/Functional/migrate_drupal/d7/Upgrade7Test.php

@@ -11,6 +11,7 @@
  *
  * @group forum
  * @group #slow
+ * @group legacy
  */
 class Upgrade7Test extends MigrateUpgradeExecuteTestBase {
 

core/modules/forum/tests/src/Kernel/ForumValidationTest.php

@@ -10,6 +10,7 @@
  * Tests forum validation constraints.
  *
  * @group forum
+ * @group legacy
  */
 class ForumValidationTest extends EntityKernelTestBase {
 

core/modules/forum/tests/src/Kernel/Migrate/d6/MigrateForumConfigsTest.php

@@ -9,6 +9,7 @@
  * Upgrade variables to forum.settings.yml.
  *
  * @group migrate_drupal_6
+ * @group legacy
  */
 class MigrateForumConfigsTest extends MigrateDrupal6TestBase {
 

core/modules/forum/tests/src/Kernel/Migrate/d6/MigrateForumTest.php

@@ -13,6 +13,7 @@
  * Tests forum migration from Drupal 6 to Drupal 8.
  *
  * @group migrate_drupal_6
+ * @group legacy
  */
 class MigrateForumTest extends MigrateNodeTestBase {
 

core/modules/forum/tests/src/Kernel/Migrate/d7/MigrateForumSettingsTest.php

@@ -8,6 +8,7 @@
  * Tests migration of Forum's variables to configuration.
  *
  * @group forum
+ * @group legacy
  */
 class MigrateForumSettingsTest extends MigrateDrupal7TestBase {