Skip to content
Snippets Groups Projects
Commit c9eb754d authored by catch's avatar catch
Browse files

Issue #3443517 by longwave: Change @dataprovider to static in FileCacheFactoryTest

parent 7dbc9947
No related branches found
No related tags found
No related merge requests found
......@@ -98,15 +98,9 @@ public function testGetConfigurationOverrides($configuration, $arguments, $class
/**
* Data provider for testGetConfigurationOverrides().
*/
public function configurationDataProvider() {
public static function configurationDataProvider() {
$data = [];
// Get a unique FileCache class.
$file_cache = $this->getMockBuilder(FileCache::class)
->disableOriginalConstructor()
->getMock();
$class = get_class($file_cache);
// Test fallback configuration.
$data['fallback-configuration'] = [
[],
......@@ -116,33 +110,33 @@ public function configurationDataProvider() {
// Test default configuration.
$data['default-configuration'] = [
['default' => ['class' => $class]],
['default' => ['class' => CustomFileCache::class]],
[],
$class,
CustomFileCache::class,
];
// Test specific per collection setting.
$data['collection-setting'] = [
['test_foo_settings' => ['class' => $class]],
['test_foo_settings' => ['class' => CustomFileCache::class]],
[],
$class,
CustomFileCache::class,
];
// Test default configuration plus specific per collection setting.
$data['default-plus-collection-setting'] = [
[
'default' => ['class' => '\stdClass'],
'test_foo_settings' => ['class' => $class],
'test_foo_settings' => ['class' => CustomFileCache::class],
],
[],
$class,
CustomFileCache::class,
];
// Test default configuration plus class specific override.
$data['default-plus-class-override'] = [
['default' => ['class' => '\stdClass']],
['class' => $class],
$class,
['class' => CustomFileCache::class],
CustomFileCache::class,
];
// Test default configuration plus class specific override plus specific
......@@ -150,10 +144,10 @@ public function configurationDataProvider() {
$data['default-plus-class-plus-collection-setting'] = [
[
'default' => ['class' => '\stdClass'],
'test_foo_settings' => ['class' => $class],
'test_foo_settings' => ['class' => CustomFileCache::class],
],
['class' => '\stdClass'],
$class,
CustomFileCache::class,
];
return $data;
......@@ -185,3 +179,5 @@ public function testGetSetPrefix() {
}
}
class CustomFileCache extends FileCache {}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment