- applied David Norman's patch to turn all <?'s into fully qualified
  <?php's.

I think you all read the mail about what has changed, I also did the tiny abstract/Editor's note update. :)

Jeroen.

- fixed two-side-bar-theme-bug-with-latest-headlines

- more small improvements

- a couple of small improvements

- some important changes to our theme API which can be summerized as:

     abstract() + article() = story()

  abstract() and article() have been merged into a new function story()
  which looks like:

  function story($story_object, $reply) {
    if (!reply) {
       // full story
    }
    else {
       // main page version / abstract
    }
  }

  This should allow you to "compress" your theme as abstract() and
  article() tended to be 98% identical.

  => I didn't really merge your themes so I leave it up to *you* to
     improved the code!!! Do it ASAP as we release drupal 2.00 in 7
     days.

  In future we'll have similar functions for other content types as
  for example:

     review($review, $reply);
     enquete($enquete, $reply);
     ...

A rather large and important update:

revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)

    $host -> $url[host]

Oh, yes, I remember, I took away the drop META tags as Dries requested, also I changed the ALT="drop.org logo" to ALT="". But Dries, I can't make everything drop independant. Since I work with the random logo's...
Also removed a style tag that I didn't use.

Jeroen.

Has he gone insane! No. I just (but that's just my opinion) made a major improvement to my theme. In one of my unentertained moments I often just browse to drop and stare at my theme for a while. ;) Then I saw that the border around my boxes was 2 pixels wide and grey. Cool. But I thought, let's try it the same way as I do the stories. With a slick 1 pixel wide black border. And so I did. And I admit, it just looks a whole lot better, slicker, smoother, professional. You probably won't notice it at all, and probably no-one would notice. But again, I'd advise you to take a look at http://jeroen.drop.org and look at the boxes before Dries updates these .gifs. Another thing, Unconed, you probably know more or this. What do you think I should use for my images? .gif or .png. What's the advantage of .png, and most of all, is it smaller in size?

Jeroen.

P.S.: another jeroen.theme is coming up. Don't even know what I changed anymore but I changed something...

I updated some things, remove some PHP lines in the comment function, that I think weren't necessary (did that in the previous commit but forgot to mention it) also I renamed all the PHP?> tags to ?>. I read in the docs at http://php.net that this is the way to go. Also I renamed all <? to <?PHP. I added a BCGOLOR again, so my theme's build up is a little nicer again. Spotted four (yes 4) bugs. I now use regular HTML to assign colors but in abstract and article, the sections were still done the old way. Fixed that now, but left them black. Oh yeah, I fixed that weird rendering of my theme I think Dries was talking about. He didn't exactly mention what was wrong but I assume that it were the links in abstract and article that didn't display at the right of the story. Because I deleted some tables I had to add COLSPAN="2". However, when I loaded my page locally on eden it displayed correct. But when I browsed to drop it didn't (in the same browser) Do you get it? I sure don't. It was the same HTML code, but seems differently parsed when coming from an outside server. Allthough I don't see why Netscape would see apache locally as something different than another one. Nevertheless, I think it's fixed.

Jeroen.

I tweaked my theme a bit, don't know if it'll help much but I was able to squeeze a table out of abstract and article. So what you'd say? Well, since the abstract function is called for every post on the main page, I thought that it'd improve it a bit. Of course it isn't much but less tables to show the same is always a good thing. Also, due of the deleted table, I could delete some backgrounds (less traffic from the server to the client) and placed them once in a TABLE header. OK, but a cool side-effect is that it's more HTML 4.01 compliant. Because BACKGROUNDs are allowed in TABLEs and I think it's a bit unclear if they can be in TD yes or no. Either way, this brought to my attention that my !DOCTYPE is strict... I started of strict though... But I think it's a better idea to switch to transitional/loose. OK I think that was it... Oh also because of the changed TABLE structure I had to delete some BGCOLORs. Again, it might be a teeny weeny bit faster, but when you see my site being build up it isn't that nice anymore. (bgcolors are displayed faster than backgrounds). Nevertheless its the result that counts not? Let's hope everything still works.

Jeroen.

- various smaller updates before I start watching Formula 1 with [a] a
  0.5 liter box of Haagen-Dhaz (Belgian Choclate) and [b] my laptop on
  my lap for drupal hacking.  Life hardly can get any better than this.

- added a new faq module with administration interface

code revision:
 - shortened and improved the code

code revision:
   - fixed a "visual-quote-glitch", i.e. a missing stripslashes()

code revision:
  - small "path"-fix with logo which could have triggered when running
    drupal in a subdirectory

- renamed upgrade file

- As I'm working down my TODO list, I updated your themes:

    $theme->comment() only takes 2 parameters ever since the comment
    system rewrite 2 months ago. Make sure to update your local tree
    before you start hacking away on your themes.

- Took all "rating logic" out of the account.module and moved it into
  a seperate module called "rating.module".  This should allow people
  to experiment with different rating heuristics/algorithms.

- The rating module also generates a "Top 100 users" page, see:
     http://drop.org/module.php?mod=rating

- Adjusted ./scripts/php-clean to ignore png files.
  (I should do it the way around and make it ignore everything but
  our php files.)

- removed all hardcoded references to "drop.org" from my theme

- forgot to wrap the links in the footer and header in t()-functions
  (Is your theme 100% translatable or not?)

- fixed small translation glitch in format_interval
- added a couple of missing t() functions
- improved the comments module, fixed the score problem Jeroen
  reported earlier -> it's slicker but I hope it won't break anything

- added UnConeD's font test to ./misc for future reference

- created nightly build script (had to create one for work too ;)

Should be OK now, also put a TD and a TR on seperate lines somewhere... seems to fix a little graphical glitch I somethimes have, but I could've just been lucky too when I reloaded last times. :)

Jeroen.

Another jeroen.theme commit is coming up since I made some changes to test the gif I changed and didn't undo them.

Jeroen.

It looks like the subject in the comments still don't show, this is because i did $comment->$subject instead of $comment->subject
Ai ai.

Jeroen.

I say Unconed's little drops and said: "Damn, how come that he, with so few pixels can create something that smooth...". That's why I went down in my .gif archive and smoothed the drop in  footerleft.gif, (the pipe with the open end in which you see a drop). It looks better now, maybe you won't see it but I do. :) I have drawn every gif pixelbased and that's why it's difficult to smoothen edges and stuff. I can't work well with the gimp and if you want certain cool effects you have to know how. Since creating a cool effect with the gimp takes like 15 weird tricks and layershuffles and filters and merges and keep transparancies and you don't get any result before you do that final step which suddenly gives you this wonderful thing. I think it's just too hard for me...
Nevertheless, here's the new footerleft.gif, you might want to check out htpp://jeroen.drop.org before Dries loads it up, otherwise you'll probably think I'm crazy :)

Jeroen.

Fixed a small bug, there was a ';' too much in a echo "" which would just be printed like normal HTML text in the abstracts' and articles' headers...

Jeroen.

Updated the stupid fonts issue (the conclusion was to use *EVEN* font sizes and not uneven as Dries recommended... bah! :)

I also added a small icon (like marvin.theme) to spice it up a bit.