Fixed Linting and Static Analysis

.drupalci/.gitlab-single-pipeline.yml

@@ -49,6 +49,9 @@ include:
 ################
 # variables:
 #   SKIP_ESLINT: '1'
+variables:
+  # https://git.drupalcode.org/project/gitlab_templates/-/commit/1b6e9ff965a417882c3142453a647008b6902c0f
+  IGNORE_PROJECT_DRUPAL_CORE_VERSION: 1
 
 
 ###################################################################################

.gitlab-ci.yml

@@ -23,7 +23,7 @@ deploystacks:
       # manually https://gitlab.com/gitlab-org/gitlab/-/issues/11549
       # Valid tags for databases are at https://git.drupalcode.org/project/drupalci_environments/-/tree/dev/db
       - _TARGET_CORE: ["10.2.x-dev"]
-        _TARGET_PHP: [ "8.1", "8.2"]
+        _TARGET_PHP: [ "8.2", "8.3" ]
         _TARGET_DB_TYPE: "mysql"
         _TARGET_DB_VERSION: "5.7"
 

date_recur.install

@@ -5,7 +5,7 @@
  * Install, update and uninstall functions for date_recur module.
  */
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use Drupal\Core\Datetime\Entity\DateFormat;
 use Drupal\Core\Entity\Entity\EntityFormDisplay;

date_recur.module

@@ -5,7 +5,7 @@
  * Contains hooks for date_recur module.
  */
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 use Drupal\Core\Render\Element;
 use Drupal\date_recur\DateRecurCachedHooks;

phpcs.xml

 <?xml version="1.0" encoding="UTF-8"?>
 <ruleset name="My Coding Standard">
+  <file>./date_recur.install</file>
+  <file>./date_recur.module</file>
   <file>./src</file>
   <file>./tests</file>
   <rule ref="PreviousNextDrupal" />

phpstan-baseline.neon

@@ -460,36 +460,11 @@ parameters:
 			count: 1
 			path: tests/src/Functional/DateRecurBasicWidgetTest.php
 
-		-
-			message: "#^Call to an undefined method Drupal\\\\Tests\\\\WebAssert\\:\\:waitForElementVisible\\(\\)\\.$#"
-			count: 1
-			path: tests/src/Functional/DateRecurInterpreterTest.php
-
-		-
-			message: "#^Parameter \\#1 \\$button of method Drupal\\\\Tests\\\\WebAssert\\:\\:buttonExists\\(\\) expects string, Drupal\\\\Core\\\\StringTranslation\\\\TranslatableMarkup given\\.$#"
-			count: 1
-			path: tests/src/Functional/DateRecurInterpreterTest.php
-
-		-
-			message: "#^Parameter \\#1 \\$button of method Drupal\\\\Tests\\\\WebAssert\\:\\:buttonNotExists\\(\\) expects string, Drupal\\\\Core\\\\StringTranslation\\\\TranslatableMarkup given\\.$#"
-			count: 1
-			path: tests/src/Functional/DateRecurInterpreterTest.php
-
-		-
-			message: "#^Parameter \\#2 \\$submit of method Drupal\\\\Tests\\\\BrowserTestBase\\:\\:submitForm\\(\\) expects string, Drupal\\\\Core\\\\StringTranslation\\\\TranslatableMarkup given\\.$#"
-			count: 2
-			path: tests/src/Functional/DateRecurInterpreterTest.php
-
 		-
 			message: "#^Property Drupal\\\\date_recur_entity_test\\\\Entity\\\\DrEntityTest\\:\\:\\$dr \\(Drupal\\\\Core\\\\Field\\\\FieldItemListInterface\\) does not accept array\\<string, string\\>\\.$#"
 			count: 1
 			path: tests/src/Kernel/DateRecurBaseFieldTest.php
 
-		-
-			message: "#^Parameter \\#1 \\$content of method Drupal\\\\KernelTests\\\\KernelTestBase\\:\\:setRawContent\\(\\) expects string, Drupal\\\\Component\\\\Render\\\\MarkupInterface given\\.$#"
-			count: 1
-			path: tests/src/Kernel/DateRecurBasicFormatterTest.php
-
 		-
 			message: "#^Property Drupal\\\\date_recur_entity_test\\\\Entity\\\\DrEntityTest\\:\\:\\$dr \\(Drupal\\\\Core\\\\Field\\\\FieldItemListInterface\\) does not accept array\\<int, array\\<string, string\\>\\>\\.$#"
 			count: 2

phpstan.neon

@@ -7,8 +7,6 @@ parameters:
     - src
     - tests
   reportUnmatchedIgnoredErrors: true
-  checkMissingIterableValueType: false
-  checkGenericClassInNonGenericObjectType: false
   fileExtensions:
     - php
     - module
@@ -42,4 +40,9 @@ parameters:
   scanDirectories:
     - vendor/rlanvin/php-rrule/
     - web/core/
+  ignoreErrors:
+    -
+      identifier: missingType.generics
+    -
+      identifier: missingType.iterableValue
 

src/Annotation/DateRecurInterpreter.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur\Annotation;
 

src/DateRange.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurCachedHooks.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurGranularityMap.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurHelper.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurHelperInterface.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurNonRecurringHelper.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurOccurrences.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 
@@ -407,7 +407,7 @@ class DateRecurOccurrences implements EventSubscriberInterface, EntityTypeListen
   protected function getBaseFieldStorages(ContentEntityTypeInterface $entityType): array {
     $baseFields = $this->entityFieldManager->getBaseFieldDefinitions($entityType->id());
     $baseFields = array_filter($baseFields,
-      fn (FieldDefinitionInterface $fieldDefinition): bool => $this->isDateRecur($fieldDefinition->getFieldStorageDefinition())
+      fn (FieldDefinitionInterface $fieldDefinition): bool => $this->isDateRecur($fieldDefinition->getFieldStorageDefinition()),
     );
 
     return array_map(

src/DateRecurPartGrid.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurRruleMap.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurRuleInterface.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurUtility.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;
 

src/DateRecurViewsHooks.php

 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Drupal\date_recur;