Issue #3074723 by dpi, jibran: Better boundary check in getHelper

src/Plugin/Field/FieldType/DateRecurItem.php

@@ -419,8 +419,12 @@ class DateRecurItem extends DateRangeItem {
       return $this->helper;
     }
 
+    $timeZoneString = $this->timezone;
+    if (empty($timeZoneString)) {
+      throw new DateRecurHelperArgumentException('Missing time zone');
+    }
+
     try {
-      $timeZoneString = $this->timezone;
       // If its not a string then cast it so a TypeError is not thrown. An empty
       // string will cause the exception to be thrown.
       $timeZone = new \DateTimeZone(is_string($timeZoneString) ? $timeZoneString : '');

tests/src/Kernel/DateRecurFieldItemTest.php

@@ -224,7 +224,7 @@ class DateRecurFieldItemTest extends KernelTestBase {
       ],
     ];
     $this->expectException(DateRecurHelperArgumentException::class);
-    $this->expectExceptionMessage('Invalid time zone');
+    $this->expectExceptionMessage('Missing time zone');
     $entity->dr[0]->getHelper();
   }