feat(DeclareStrictTypes): Add Slevomat sniff for declare strict_types (#3407995)

coder_sniffer/Drupal/ruleset.xml

@@ -123,6 +123,14 @@
  <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" />
  <rule ref="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses" />
  <rule ref="SlevomatCodingStandard.PHP.ShortList" />
+ <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
+  <exclude name="SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing"/>
+  <properties>
+   <property name="linesCountBeforeDeclare" value="1"/>
+   <property name="linesCountAfterDeclare" value="1"/>
+   <property name="spacesCountAroundEqualsSign" value="0"/>
+  </properties>
+ </rule>
 
  <rule ref="Squiz.Arrays.ArrayDeclaration" />
  <!-- Disable some error messages that we do not want. -->
@@ -298,7 +306,7 @@
  <exclude-pattern>*/\.svn/*</exclude-pattern>
  <exclude-pattern>*/\.hg/*</exclude-pattern>
  <exclude-pattern>*/\.bzr/*</exclude-pattern>
- 
+
  <!-- Ignore minified CSS files.-->
  <exclude-pattern>*\.min\.css$</exclude-pattern>
 </ruleset>

tests/Drupal/bad/BadUnitTest.php

@@ -69,12 +69,13 @@ class BadUnitTest extends CoderSniffUnitTest
         case 'bad.module':
             return [
                 1  => 1,
-                12 => 1,
-                19 => 1,
-                26 => 1,
-                33 => 1,
-                44 => 1,
-                45 => 1,
+                7  => 1,
+                14 => 1,
+                21 => 1,
+                28 => 1,
+                35 => 1,
+                46 => 1,
+                47 => 1,
             ];
         case 'bad.php':
             return [
@@ -404,7 +405,7 @@ class BadUnitTest extends CoderSniffUnitTest
     {
         switch ($testFile) {
         case 'bad.module':
-            return [7 => 1];
+            return [9 => 1];
         case 'bad.php':
             return [
                 14  => 1,

tests/Drupal/bad/bad.module

@@ -4,6 +4,8 @@
  * Bad examples of install hooks in a module file.
  */
 
+declare(strict_types = 1);
+
 define('UNPREFIXED_CONSTANT', 'invalid');
 
 /**

tests/Drupal/good/good.module

@@ -7,4 +7,6 @@
  * It is used to check sniffs that run on .module files but skip .php files.
  */
 
+declare(strict_types=1);
+
 define('GOOD_FOO_BAR', 5);