#689758 by solotandem: Fix code so it runs in 7.x-alpha 1.

coder_review/CHANGELOG.txt

@@ -2,6 +2,14 @@
 
 Coder Review 7.x-3.x, xxxx-xx-xx
 ---------------------------------
+#689758 by solotandem:
+ - Fix code so it runs in 7.x-alpha 1
+ - coder_review.module
+   - set $form_state['rebuild'] to TRUE in coder_review_page_form_submit
+   - form api no longer does an automatic rebuild simply by setting $form_state['storage'] 
+ - _coder_review_7x_optional_block_review_callback
+   - remove opportunistic search for module name (path may include a period)
+
 #666714 by dereine :
  - Fixed parameters in coder_review_drush_help().
 #607592 by japerry, stella :

coder_review/coder_review.module

@@ -689,7 +689,11 @@ function _coder_review_get_default_settings($arg = 'default') {
  * Implements hook_submit().
  */
 function coder_review_page_form_submit($form, &$form_state) {
+  // In D7, setting values in this variable does not trigger a form rebuild.
   $form_state['storage'] = $form_state['values'];
+
+  // Rebuild form with user selections.
+  $form_state['rebuild'] = TRUE;
 }
 
 /**

coder_review/includes/coder_review_7x.inc

@@ -994,9 +994,9 @@ function _coder_review_7x_optional_block_review_callback(&$coder_args, $review,
   }
 
   // Find out the info filename and load it.
-  $pos = strpos($filename, '.');
-  $modulename = substr($filename, 0, $pos);
-  $ini = parse_ini_file($modulename .'.info');
+  $path_info = pathinfo($filename);
+  list($modulename) = explode('.', $path_info['basename'], 2);
+  $ini = parse_ini_file($path_info['dirname'] . '/' . $modulename . '.info');
 
   // Check if the dependency has been declared.
   $dependency_declared = (isset($ini['dependencies']) && is_array($ini['dependencies'])) ? in_array('block', $ini['dependencies']) : FALSE;