Added a sniff to detect drupal_add_js() usage in hook_page_build().

coder_sniffer/DrupalPractice/Sniffs/FunctionDefinitions/HookInitCssSniff.php

@@ -46,7 +46,7 @@ class DrupalPractice_Sniffs_FunctionDefinitions_HookInitCssSniff extends Drupal_
 
         $fileName = substr(basename($phpcsFile->getFilename()), 0, -7);
         $tokens   = $phpcsFile->getTokens();
-        if ($tokens[$stackPtr]['content'] !== ($fileName.'_init')) {
+        if ($tokens[$stackPtr]['content'] !== ($fileName.'_init') && $tokens[$stackPtr]['content'] !== ($fileName.'_page_build')) {
             return;
         }
 
@@ -67,8 +67,13 @@ class DrupalPractice_Sniffs_FunctionDefinitions_HookInitCssSniff extends Drupal_
                 if ($opener !== false
                     && $tokens[$opener]['code'] === T_OPEN_PARENTHESIS
                 ) {
+                    if ($tokens[$stackPtr]['content'] === ($fileName.'_init')) {
                         $warning = 'Do not use %s() in hook_init(), move it to your page/form callback or use hook_page_build() instead';
                         $phpcsFile->addWarning($warning, $string, 'AddFunctionFound', array($tokens[$string]['content']));
+                    } else {
+                        $warning = 'Do not use %s() in hook_page_build(), use #attached on the $page render array instead';
+                        $phpcsFile->addWarning($warning, $string, 'AddFunctionFoundPageBuild', array($tokens[$string]['content']));
+                    }
                 }
             }
 

coder_sniffer/DrupalPractice/Test/FunctionDefinitions/HookInitCssUnitTest.php

@@ -35,7 +35,10 @@ class DrupalPractice_Sniffs_FunctionDefinitions_HookInitCssUnitTest extends Code
      */
     public function getWarningList($testFile)
     {
-        return array(7 => 1);
+        return array(
+                7 => 1,
+                14 => 1,
+               );
 
     }//end getWarningList()
 

coder_sniffer/DrupalPractice/Test/FunctionDefinitions/test.module

@@ -6,3 +6,10 @@
 function test_init() {
   drupal_add_css('somefile.css');
 }
+
+/**
+ * Implements hook_page_build().
+ */
+function test_page_build($page) {
+  drupal_add_css('somefile.css');
+}