Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
automatic_updates-3449631
Manage
Activity
Members
Labels
Plan
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Issue forks
automatic_updates-3449631
Commits
d897a410
Commit
d897a410
authored
3 years ago
by
Adam G-H
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3262244
by phenaproxima: HEAD is broken because I made Zeus mad
parent
1b42c6f3
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
tests/src/Functional/AutomaticUpdatesFunctionalTestBase.php
+1
-2
1 addition, 2 deletions
tests/src/Functional/AutomaticUpdatesFunctionalTestBase.php
tests/src/Functional/ReadinessValidationTest.php
+4
-5
4 additions, 5 deletions
tests/src/Functional/ReadinessValidationTest.php
with
5 additions
and
7 deletions
tests/src/Functional/AutomaticUpdatesFunctionalTestBase.php
+
1
−
2
View file @
d897a410
...
...
@@ -59,8 +59,7 @@ abstract class AutomaticUpdatesFunctionalTestBase extends BrowserTestBase {
];
}
file_put_contents
(
$services_file
,
Yaml
::
encode
(
$services
));
// Ensure the container is rebuilt ASAP.
$this
->
kernel
->
invalidateContainer
();
$this
->
rebuildContainer
();
}
/**
...
...
This diff is collapsed.
Click to expand it.
tests/src/Functional/ReadinessValidationTest.php
+
4
−
5
View file @
d897a410
...
...
@@ -373,11 +373,6 @@ class ReadinessValidationTest extends AutomaticUpdatesFunctionalTestBase {
* Tests that stored validation results are deleted after an update.
*/
public
function
testStoredResultsClearedAfterUpdate
():
void
{
// Because all actual staging operations are bypassed by
// package_manager_bypass, disable this validator because it will complain
// if there's no actual Composer data to inspect.
$this
->
disableValidators
([
'automatic_updates.staged_projects_validator'
]);
$assert_session
=
$this
->
assertSession
();
$page
=
$this
->
getSession
()
->
getPage
();
$this
->
drupalLogin
(
$this
->
checkerRunnerUser
);
...
...
@@ -396,6 +391,10 @@ class ReadinessValidationTest extends AutomaticUpdatesFunctionalTestBase {
'automatic_updates_test'
,
'package_manager_bypass'
,
]);
// Because all actual staging operations are bypassed by
// package_manager_bypass, disable this validator because it will complain
// if there's no actual Composer data to inspect.
$this
->
disableValidators
([
'automatic_updates.staged_projects_validator'
]);
// The error should be persistently visible, even after the checker stops
// flagging it.
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment