Issue #3358012 by phenaproxima, Wim Leers: StageBase::stageDirectoryExists() breaks on PreCreate

package_manager/src/StageBase.php

@@ -746,10 +746,9 @@ abstract class StageBase implements LoggerAwareInterface {
    */
   public function stageDirectoryExists(): bool {
     try {
-      $this->getStageDirectory();
-      return TRUE;
+      return is_dir($this->getStageDirectory());
     }
-    catch (\LogicException $e) {
+    catch (\LogicException) {
       return FALSE;
     }
   }

package_manager/tests/src/Kernel/StageBaseTest.php

@@ -655,6 +655,16 @@ class StageBaseTest extends PackageManagerKernelTestBase {
    * @covers ::stageDirectoryExists
    */
   public function testStageDirectoryExists(): void {
+    // Ensure that stageDirectoryExists() returns an accurate result during
+    // pre-create.
+    $listener = function (StageEvent $event): void {
+      $stage = $event->stage;
+      // The directory should not exist yet, because we are still in pre-create.
+      $this->assertDirectoryDoesNotExist($stage->getStageDirectory());
+      $this->assertFalse($stage->stageDirectoryExists());
+    };
+    $this->addEventTestListener($listener, PreCreateEvent::class);
+
     $stage = $this->createStage();
     $this->assertFalse($stage->stageDirectoryExists());
     $stage->create();