Issue #3280923 by phenaproxima: CronUpdater::begin() should throw an exception...

Issue #3280923 by phenaproxima: CronUpdater::begin() should throw an exception of if cron updates are disabled

src/CronUpdater.php

@@ -93,6 +93,19 @@ class CronUpdater extends Updater {
     }
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  public function begin(array $project_versions, ?int $timeout = 300): string {
+    // Prevent mischievous callers from starting an update even if unattended
+    // updates are disabled. To start an update programmatically, use
+    // \Drupal\automatic_updates\Updater::begin().
+    if ($this->getMode() === static::DISABLED) {
+      throw new \LogicException('Unattended updates are disabled.');
+    }
+    return parent::begin($project_versions, $timeout);
+  }
+
   /**
    * Performs the update.
    *

tests/src/Functional/UpdaterFormTest.php

@@ -57,6 +57,7 @@ class UpdaterFormTest extends AutomaticUpdatesFunctionalTestBase {
       'access site in maintenance mode',
       'administer modules',
       'access site reports',
+      'view update notifications',
     ]);
     $this->drupalLogin($user);
     $this->checkForUpdates();

tests/src/Kernel/CronUpdaterTest.php

@@ -38,6 +38,7 @@ class CronUpdaterTest extends AutomaticUpdatesKernelTestBase {
   protected static $modules = [
     'automatic_updates',
     'automatic_updates_test',
+    'user',
   ];
 
   /**
@@ -328,4 +329,17 @@ class CronUpdaterTest extends AutomaticUpdatesKernelTestBase {
     }
   }
 
+  /**
+   * Tests that the cron updater throws an exception if started while disabled.
+   */
+  public function testExceptionWhenDisabled(): void {
+    $this->config('automatic_updates.settings')
+      ->set('cron', CronUpdater::DISABLED)
+      ->save();
+
+    $this->expectExceptionMessage('Unattended updates are disabled.');
+    $this->container->get('automatic_updates.cron_updater')
+      ->begin(['drupal' => '9.8.1']);
+  }
+
 }