Issue #3355609 by yash.rode, Wim Leers, phenaproxima: All injected services...

Issue #3355609 by yash.rode, Wim Leers, phenaproxima: All injected services should be marked readonly

src/UpdateStage.php

@@ -55,7 +55,7 @@ class UpdateStage extends StageBase {
    *   The failure marker service.
    */
   public function __construct(
-    protected ComposerInspector $composerInspector,
+    protected readonly ComposerInspector $composerInspector,
     PathLocator $pathLocator,
     BeginnerInterface $beginner,
     StagerInterface $stager,

src/Validation/AdminStatusCheckMessages.php

@@ -51,12 +51,12 @@ final class AdminStatusCheckMessages implements ContainerInjectionInterface {
    *   The renderer service.
    */
   public function __construct(
-    protected StatusChecker $statusChecker,
-    protected AdminContext $adminContext,
-    protected AccountProxyInterface $currentUser,
-    protected CurrentRouteMatch $currentRouteMatch,
-    protected CronUpdateStage $stage,
-    protected RendererInterface $renderer
+    private readonly StatusChecker $statusChecker,
+    private readonly AdminContext $adminContext,
+    private readonly AccountProxyInterface $currentUser,
+    private readonly CurrentRouteMatch $currentRouteMatch,
+    private readonly CronUpdateStage $stage,
+    private readonly RendererInterface $renderer
   ) {}
 
   /**

src/Validation/StatusCheckRequirements.php

@@ -34,8 +34,10 @@ final class StatusCheckRequirements implements ContainerInjectionInterface {
    * @param \Drupal\Core\Datetime\DateFormatterInterface $dateFormatter
    *   The date formatter service.
    */
-  public function __construct(protected StatusChecker $statusChecker, protected DateFormatterInterface $dateFormatter) {
-  }
+  public function __construct(
+    private readonly StatusChecker $statusChecker,
+    private readonly DateFormatterInterface $dateFormatter
+  ) {}
 
   /**
    * {@inheritdoc}

src/Validation/StatusChecker.php

@@ -48,11 +48,11 @@ final class StatusChecker implements EventSubscriberInterface {
    */
   public function __construct(
     KeyValueExpirableFactoryInterface $key_value_expirable_factory,
-    protected TimeInterface $time,
-    protected EventDispatcherInterface $eventDispatcher,
-    protected UpdateStage $updateStage,
-    protected CronUpdateStage $cronUpdateStage,
-    protected int $resultsTimeToLive,
+    private readonly TimeInterface $time,
+    private readonly EventDispatcherInterface $eventDispatcher,
+    private readonly UpdateStage $updateStage,
+    private readonly CronUpdateStage $cronUpdateStage,
+    private readonly int $resultsTimeToLive,
   ) {
     $this->keyValueExpirable = $key_value_expirable_factory->get('automatic_updates');
   }

src/Validator/CronFrequencyValidator.php

@@ -69,11 +69,11 @@ class CronFrequencyValidator implements EventSubscriberInterface {
    *   The lock service.
    */
   public function __construct(
-    protected ConfigFactoryInterface $configFactory,
-    protected ModuleHandlerInterface $moduleHandler,
-    protected StateInterface $state,
-    protected TimeInterface $time,
-    protected LockBackendInterface $lock,
+    private readonly ConfigFactoryInterface $configFactory,
+    private readonly ModuleHandlerInterface $moduleHandler,
+    private readonly StateInterface $state,
+    private readonly TimeInterface $time,
+    private readonly LockBackendInterface $lock,
   ) {}
 
   /**

src/Validator/CronServerValidator.php

@@ -57,8 +57,8 @@ final class CronServerValidator implements EventSubscriberInterface {
    */
   public function __construct(
     RequestStack $request_stack,
-    protected ConfigFactoryInterface $configFactory,
-    protected ModuleHandlerInterface $moduleHandler,
+    private readonly ConfigFactoryInterface $configFactory,
+    private readonly ModuleHandlerInterface $moduleHandler,
   ) {
     $this->request = $request_stack->getCurrentRequest();
   }

src/Validator/RequestedUpdateValidator.php

@@ -28,8 +28,8 @@ class RequestedUpdateValidator implements EventSubscriberInterface {
    *   The path locator service.
    */
   public function __construct(
-    private ComposerInspector $composerInspector,
-    private PathLocator $pathLocator,
+    private readonly ComposerInspector $composerInspector,
+    private readonly PathLocator $pathLocator,
   ) {}
 
   /**

src/Validator/ScaffoldFilePermissionsValidator.php

@@ -35,8 +35,8 @@ final class ScaffoldFilePermissionsValidator implements EventSubscriberInterface
    *   The path locator service.
    */
   public function __construct(
-    private ComposerInspector $composerInspector,
-    private PathLocator $pathLocator,
+    private readonly ComposerInspector $composerInspector,
+    private readonly PathLocator $pathLocator,
   ) {}
 
   /**

src/Validator/StagedDatabaseUpdateValidator.php

@@ -28,7 +28,7 @@ class StagedDatabaseUpdateValidator implements EventSubscriberInterface {
    * @param \Drupal\package_manager\Validator\StagedDBUpdateValidator $stagedDBUpdateValidator
    *   The Staged DB Update Validator service.
    */
-  public function __construct(protected StagedDBUpdateValidator $stagedDBUpdateValidator) {
+  public function __construct(private readonly StagedDBUpdateValidator $stagedDBUpdateValidator) {
   }
 
   /**

src/Validator/StagedProjectsValidator.php

@@ -32,8 +32,10 @@ final class StagedProjectsValidator implements EventSubscriberInterface {
    * @param \Drupal\package_manager\ComposerInspector $composerInspector
    *   The Composer inspector service.
    */
-  public function __construct(private PathLocator $pathLocator, private ComposerInspector $composerInspector) {
-  }
+  public function __construct(
+    private readonly PathLocator $pathLocator,
+    private readonly ComposerInspector $composerInspector
+  ) {}
 
   /**
    * Validates the staged packages.

src/Validator/VersionPolicy/TargetVersionInstallable.php

@@ -29,7 +29,7 @@ final class TargetVersionInstallable implements ContainerInjectionInterface {
    * @param \Drupal\Core\Config\ConfigFactoryInterface $configFactory
    *   The config factory service.
    */
-  public function __construct(private ConfigFactoryInterface $configFactory) {}
+  public function __construct(private readonly ConfigFactoryInterface $configFactory) {}
 
   /**
    * {@inheritdoc}

src/Validator/VersionPolicyValidator.php

@@ -49,9 +49,9 @@ final class VersionPolicyValidator implements EventSubscriberInterface {
    *   The Composer inspector service.
    */
   public function __construct(
-    private ClassResolverInterface $classResolver,
-    private PathLocator $pathLocator,
-    private ComposerInspector $composerInspector,
+    private readonly ClassResolverInterface $classResolver,
+    private readonly PathLocator $pathLocator,
+    private readonly ComposerInspector $composerInspector,
   ) {}
 
   /**