Issue #3312085 by phenaproxima, omkar.podey, immaculatexavier: UpdateReady...

Issue #3312085 by phenaproxima, omkar.podey, immaculatexavier: UpdateReady hides the Continue button if StatusCheckEvent only returns warnings

src/Form/UpdateReady.php

@@ -17,6 +17,7 @@ use Drupal\package_manager\Exception\ApplyFailedException;
 use Drupal\package_manager\Event\StatusCheckEvent;
 use Drupal\package_manager\Exception\StageException;
 use Drupal\package_manager\Exception\StageOwnershipException;
+use Drupal\system\SystemManager;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
@@ -218,8 +219,11 @@ final class UpdateReady extends FormBase {
       $this->eventDispatcher->dispatch($event);
       /** @var \Drupal\package_manager\ValidationResult[] $results */
       $results = $event->getResults();
-      if (!empty($results)) {
-        $this->displayResults($results, $this->messenger(), $this->renderer);
+      // This will have no effect if $results is empty.
+      $this->displayResults($results, $this->messenger(), $this->renderer);
+      // If any errors occurred, return the form early so the user cannot
+      // continue.
+      if ($this->getOverallSeverity($results) === SystemManager::REQUIREMENT_ERROR) {
         return $form;
       }
     }

tests/src/Functional/UpdaterFormTest.php

@@ -781,6 +781,28 @@ class UpdaterFormTest extends AutomaticUpdatesFunctionalTestBase {
     $assert_session->buttonExists('Cancel update');
   }
 
+  /**
+   * Tests that update can be completed even if a status check throws a warning.
+   */
+  public function testContinueOnWarning(): void {
+    $session = $this->getSession();
+
+    $this->setCoreVersion('9.8.0');
+    $this->checkForUpdates();
+    $this->drupalGet('/admin/modules/automatic-update');
+    $session->getPage()->pressButton('Update to 9.8.1');
+    $this->checkForMetaRefresh();
+    $this->assertUpdateStagedTimes(1);
+
+    $warning = ValidationResult::createWarning(['Some warning.']);
+    TestSubscriber::setTestResult([$warning], StatusCheckEvent::class);
+    $session->reload();
+
+    $assert_session = $this->assertSession();
+    $assert_session->buttonExists('Continue');
+    $assert_session->pageTextContains('Some warning.');
+  }
+
   /**
    * Sets an error message, runs readiness checks, and asserts it is displayed.
    *