Issue #3259196 by kunal.sachdev, phenaproxima: Ensure all dataProvider methods...

Issue #3259196 by kunal.sachdev, phenaproxima: Ensure all dataProvider methods have index keys to make tests more helpful

package_manager/tests/src/Build/TemplateProjectTestBase.php

@@ -30,8 +30,8 @@ abstract class TemplateProjectTestBase extends QuickStartTestBase {
    */
   public function providerTemplate(): array {
     return [
-      ['RecommendedProject'],
-      ['LegacyProject'],
+      'RecommendedProject' => ['RecommendedProject'],
+      'LegacyProject' => ['LegacyProject'],
     ];
   }
 

package_manager/tests/src/Kernel/FileSyncerFactoryTest.php

@@ -24,9 +24,9 @@ class FileSyncerFactoryTest extends KernelTestBase {
    */
   public function providerFactory(): array {
     return [
-      ['rsync'],
-      ['php'],
-      [NULL],
+      'rsync file syncer' => ['rsync'],
+      'php file syncer' => ['php'],
+      'no preference' => [NULL],
     ];
   }
 

package_manager/tests/src/Kernel/StageEventsTest.php

@@ -106,10 +106,10 @@ class StageEventsTest extends PackageManagerKernelTestBase implements EventSubsc
    */
   public function providerValidationResults(): array {
     return [
-      [PreCreateEvent::class],
-      [PreRequireEvent::class],
-      [PreApplyEvent::class],
-      [PreDestroyEvent::class],
+      'PreCreateEvent' => [PreCreateEvent::class],
+      'PreRequireEvent' => [PreRequireEvent::class],
+      'PreApplyEvent' => [PreApplyEvent::class],
+      'PreDestroyEvent' => [PreDestroyEvent::class],
     ];
   }
 

tests/src/Kernel/ReadinessValidation/PackageManagerReadinessChecksTest.php

@@ -45,11 +45,11 @@ class PackageManagerReadinessChecksTest extends AutomaticUpdatesKernelTestBase {
    */
   public function providerValidatorInvoked(): array {
     return [
-      ['package_manager.validator.composer_executable'],
-      ['package_manager.validator.disk_space'],
-      ['package_manager.validator.pending_updates'],
-      ['package_manager.validator.file_system'],
-      ['package_manager.validator.composer_settings'],
+      'Composer executable validator' => ['package_manager.validator.composer_executable'],
+      'Disk space validator' => ['package_manager.validator.disk_space'],
+      'Pending updates validator' => ['package_manager.validator.pending_updates'],
+      'File system validator' => ['package_manager.validator.file_system'],
+      'Composer settings validator' => ['package_manager.validator.composer_settings'],
     ];
   }
 

tests/src/Kernel/ReadinessValidation/SettingsValidatorTest.php

@@ -30,8 +30,8 @@ class SettingsValidatorTest extends AutomaticUpdatesKernelTestBase {
     ]);
 
     return [
-      [TRUE, [$result]],
-      [FALSE, []],
+      'HTTP fallback enabled' => [TRUE, [$result]],
+      'HTTP fallback disabled' => [FALSE, []],
     ];
   }
 

tests/src/Kernel/ReadinessValidation/StagedDatabaseUpdateValidatorTest.php

@@ -94,8 +94,8 @@ class StagedDatabaseUpdateValidatorTest extends AutomaticUpdatesKernelTestBase {
   public function providerFileChanged(): array {
     $scenarios = [];
     foreach (static::SUFFIXES as $suffix) {
-      $scenarios[] = [$suffix, FALSE];
-      $scenarios[] = [$suffix, TRUE];
+      $scenarios["$suffix kept"] = [$suffix, FALSE];
+      $scenarios["$suffix deleted"] = [$suffix, TRUE];
     }
     return $scenarios;
   }