Skip to content
Snippets Groups Projects
Commit 7e574c13 authored by Kunal Sachdev's avatar Kunal Sachdev Committed by Ted Bowman
Browse files

Issue #3357721 by kunal.sachdev, yash.rode, phenaproxima:...

Issue #3357721 by kunal.sachdev, yash.rode, phenaproxima: PhpExtensionsValidator's wording is needlessly verbose
parent feebd358
No related branches found
No related tags found
No related merge requests found
......@@ -27,7 +27,7 @@ final class PhpExtensionsValidator extends PackageManagerPhpExtensionsValidator
*/
public function validateXdebug(PreOperationStageEvent $event): void {
if ($this->isExtensionLoaded('xdebug') && $event->stage instanceof CronUpdateStage) {
$event->addError([$this->t("Xdebug is enabled, currently Cron Updates are not allowed while it is enabled. If Xdebug is not disabled you will not receive security and other updates during cron.")]);
$event->addError([$this->t("Unattended updates are not allowed while Xdebug is enabled. You cannot receive updates, including security updates, until it is disabled.")]);
}
elseif ($event instanceof StatusCheckEvent) {
parent::validateXdebug($event);
......
......@@ -37,7 +37,7 @@ class PhpExtensionsValidatorTest extends AutomaticUpdatesKernelTestBase {
t('Xdebug is enabled, which may have a negative performance impact on Package Manager and any modules that use it.'),
]);
$error_result = ValidationResult::createError([
t("Xdebug is enabled, currently Cron Updates are not allowed while it is enabled. If Xdebug is not disabled you will not receive security and other updates during cron."),
t("Unattended updates are not allowed while Xdebug is enabled. You cannot receive updates, including security updates, until it is disabled."),
]);
$config = $this->config('automatic_updates.settings');
......@@ -88,7 +88,7 @@ class PhpExtensionsValidatorTest extends AutomaticUpdatesKernelTestBase {
$this->container->get('cron')->run();
// The update should have been staged, but then stopped with an error.
$this->assertUpdateStagedTimes(1);
$this->assertTrue($logger->hasRecordThatContains("Xdebug is enabled, currently Cron Updates are not allowed while it is enabled. If Xdebug is not disabled you will not receive security and other updates during cron.", RfcLogLevel::ERROR));
$this->assertTrue($logger->hasRecordThatContains("Unattended updates are not allowed while Xdebug is enabled. You cannot receive updates, including security updates, until it is disabled.", RfcLogLevel::ERROR));
}
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment