Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
automatic_updates-3295830
Manage
Activity
Members
Labels
Plan
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Issue forks
automatic_updates-3295830
Commits
b001cf3b
Commit
b001cf3b
authored
5 years ago
by
Lucas Hedding
Committed by
Lucas Hedding
5 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3094513
by heddn: Try/catch /Exception to rollback entire update if anything happens
parent
45cfddf8
No related branches found
Branches containing commit
Tags
8.x-1.0-rc2
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
drupalci.yml
+0
-5
0 additions, 5 deletions
drupalci.yml
src/Services/InPlaceUpdate.php
+12
-2
12 additions, 2 deletions
src/Services/InPlaceUpdate.php
with
12 additions
and
7 deletions
drupalci.yml
+
0
−
5
View file @
b001cf3b
...
...
@@ -9,11 +9,6 @@ build:
sniff-all-files
:
true
halt-on-fail
:
true
testing
:
container_command
:
commands
:
-
cd ${SOURCE_DIR} && sudo -u www-data curl https://www.drupal.org/files/issues/2019-10-07/3085728.patch | git apply -
-
cd ${SOURCE_DIR} && sudo -u www-data curl https://www.drupal.org/files/issues/2019-10-16/3088400-8_0.patch | git apply -
-
cd ${SOURCE_DIR} && sudo -u www-data curl https://www.drupal.org/files/issues/2019-10-16/3088447.patch | git apply -
# run_tests task is executed several times in order of performance speeds.
# halt-on-fail can be set on the run_tests tasks in order to fail fast.
# suppress-deprecations is false in order to be alerted to usages of
...
...
This diff is collapsed.
Click to expand it.
src/Services/InPlaceUpdate.php
+
12
−
2
View file @
b001cf3b
...
...
@@ -149,8 +149,18 @@ class InPlaceUpdate implements UpdateInterface {
$modified
=
$this
->
checkModifiedFiles
(
$metadata
,
$archive
);
if
(
!
$modified
&&
$this
->
backup
(
$archive
,
$project_root
))
{
$this
->
logger
->
info
(
'In place update has started.'
);
$success
=
$this
->
processUpdate
(
$archive
,
$project_root
);
$this
->
logger
->
info
(
'In place update has finished.'
);
try
{
$success
=
$this
->
processUpdate
(
$archive
,
$project_root
);
$this
->
logger
->
info
(
'In place update has finished.'
);
}
catch
(
\Throwable
$throwable
)
{
$this
->
logger
->
info
(
'In place update failed.'
);
watchdog_exception
(
$throwable
);
}
catch
(
\Exception
$exception
)
{
$this
->
logger
->
info
(
'In place update failed.'
);
watchdog_exception
(
$exception
);
}
if
(
$success
)
{
$process
=
automatic_updates_console_command
(
'updatedb:status'
);
if
(
$success
&&
$process
->
getOutput
())
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment