Get the rename right

package_manager/config/schema/package_manager.schema.yml

@@ -2,6 +2,6 @@ package_manager.settings:
   type: config_object
   label: 'Package Manager settings'
   mapping:
-    file_copier:
+    file_syncer:
       type: string
-      label: 'Which file copier to use, or NULL to auto-detect'
+      label: 'Which file syncer to use, or NULL to auto-detect'

package_manager/src/FileSyncerFactory.php

@@ -9,12 +9,12 @@ use PhpTuf\ComposerStager\Infrastructure\FileSyncer\FileSyncerInterface;
 use Symfony\Component\Process\ExecutableFinder;
 
 /**
- * A file syncer factory which returns file copiers according to configuration.
+ * A file syncer factory which returns file syncers according to configuration.
  */
 class FileSyncerFactory implements FileSyncerFactoryInterface {
 
   /**
-   * The decorated file copier factory.
+   * The decorated file syncer factory.
    *
    * @var \PhpTuf\ComposerStager\Infrastructure\FileSyncer\FileSyncerFactoryInterface
    */
@@ -46,17 +46,17 @@ class FileSyncerFactory implements FileSyncerFactoryInterface {
    *
    * @param \Symfony\Component\Process\ExecutableFinder $executable_finder
    *   The Symfony executable finder.
-   * @param \PhpTuf\ComposerStager\Infrastructure\FileSyncer\FileSyncerInterface $php_file_copier
+   * @param \PhpTuf\ComposerStager\Infrastructure\FileSyncer\FileSyncerInterface $php_file_syncer
    *   The PHP file syncer service.
-   * @param \PhpTuf\ComposerStager\Infrastructure\FileSyncer\FileSyncerInterface $rsync_file_copier
+   * @param \PhpTuf\ComposerStager\Infrastructure\FileSyncer\FileSyncerInterface $rsync_file_syncer
    *   The rsync file syncer service.
    * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
    *   The config factory service.
    */
-  public function __construct(ExecutableFinder $executable_finder, FileSyncerInterface $php_file_copier, FileSyncerInterface $rsync_file_copier, ConfigFactoryInterface $config_factory) {
-    $this->decorated = new StagerFileSyncerFactory($executable_finder, $php_file_copier, $rsync_file_copier);
-    $this->phpFileSyncer = $php_file_copier;
-    $this->rsyncFileSyncer = $rsync_file_copier;
+  public function __construct(ExecutableFinder $executable_finder, FileSyncerInterface $php_file_syncer, FileSyncerInterface $rsync_file_syncer, ConfigFactoryInterface $config_factory) {
+    $this->decorated = new StagerFileSyncerFactory($executable_finder, $php_file_syncer, $rsync_file_syncer);
+    $this->phpFileSyncer = $php_file_syncer;
+    $this->rsyncFileSyncer = $rsync_file_syncer;
     $this->configFactory = $config_factory;
   }
 
@@ -64,10 +64,10 @@ class FileSyncerFactory implements FileSyncerFactoryInterface {
    * {@inheritdoc}
    */
   public function create(): FileSyncerInterface {
-    $copier = $this->configFactory->get('package_manager.settings')
-      ->get('file_copier');
+    $syncer = $this->configFactory->get('package_manager.settings')
+      ->get('file_syncer');
 
-    switch ($copier) {
+    switch ($syncer) {
       case 'rsync':
         return $this->rsyncFileSyncer;
 

package_manager/tests/src/Kernel/FileCopierFactoryTest.php

@@ -31,36 +31,36 @@ class FileCopierFactoryTest extends KernelTestBase {
   }
 
   /**
-   * Tests creating a file copier using our specialized factory class.
+   * Tests creating a file syncer using our specialized factory class.
    *
-   * @param string|null $configured_copier
-   *   The copier to use, as configured in automatic_updates.settings. Can be
+   * @param string|null $configured_syncer
+   *   The syncer to use, as configured in automatic_updates.settings. Can be
    *   'rsync', 'php', or NULL.
    *
    * @dataProvider providerFactory
    */
-  public function testFactory(?string $configured_copier): void {
-    $factory = $this->container->get('package_manager.file_copier.factory');
+  public function testFactory(?string $configured_syncer): void {
+    $factory = $this->container->get('package_manager.file_syncer.factory');
 
-    switch ($configured_copier) {
+    switch ($configured_syncer) {
       case 'rsync':
-        $expected_copier = $this->container->get('package_manager.file_copier.rsync');
+        $expected_syncer = $this->container->get('package_manager.file_syncer.rsync');
         break;
 
       case 'php':
-        $expected_copier = $this->container->get('package_manager.file_copier.php');
+        $expected_syncer = $this->container->get('package_manager.file_syncer.php');
         break;
 
       default:
-        $expected_copier = $factory->create();
+        $expected_syncer = $factory->create();
         break;
     }
 
     $this->config('package_manager.settings')
-      ->set('file_copier', $configured_copier)
+      ->set('file_syncer', $configured_syncer)
       ->save();
 
-    $this->assertSame($expected_copier, $factory->create());
+    $this->assertSame($expected_syncer, $factory->create());
   }
 
 }