>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3631964. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !418 >>> <h3>Problem/Motivation</h3> <p>Found by the release audit of 1.x at e9bcd460, with a method-body clone detector run over the whole module (tests included) and a second pass grouping entity queries by their conditions.</p> <ul> <li><strong>An allotment's release lead is put into words six times</strong>: "Held until taken" or "an interval before the slot", in <code>ResourceAllotmentListBuilder</code> and <code>PresetAllotmentListBuilder</code> (byte-identical methods), <code>SlotAllotmentsController</code>, <code>ResourceAllotmentsController</code>, <code>PresetTariffsController</code> (which says "before each slot") and <code>ApplyTariffPresetForm</code>.</li> <li><strong>The grades a tariff prices are read twice</strong>: <code>VenueAvailabilityBound::getGradeIds()</code> and <code>PlaceTariffMatcher::getGradeIds()</code>.</li> <li><strong>Grant purges are written for each kind of grant</strong>: deleting lapsed grants on cron, and the grants naming a row being deleted, in <code>ManagerHooks</code> and again in <code>OperatorHooks</code>.</li> <li><strong>The optional guarantee amount is built, checked and stored twice</strong>, in <code>CaptureGuaranteeAction</code> and <code>ReleaseGuaranteeAction</code>.</li> <li><strong>Opening a signed link to its order is written twice</strong>: <code>TicketController::getOrderForToken()</code> and <code>CancelController::getOrderForToken()</code>.</li> <li><strong>A venue's sections as options are written twice</strong>: <code>VenuePlaceFilterForm::getSectionOptions()</code> repeats <code>VenuePlaceOptionsTrait::getSectionOptions()</code>, and the filter form asks it twice per build.</li> <li><strong>Three method names in the docs no longer exist</strong>: <code>heldQuantities()</code> in cart.md is <code>getHeldQuantities()</code>, <code>messageSettingValue()</code> in booker-messages.md is <code>getMessageSettingValue()</code>, <code>BookingWorkflowStarter::onHeld()</code> in resource-type-design.md is <code>start()</code>.</li> <li><strong>The resource type page still reads as a plan.</strong> It says types and tenants have no admin forms yet (both have them), keeps an open decision between a config and a content entity (a config entity shipped), and lists migration and phasing steps for work that has shipped.</li> <li><strong>"Delete the records naming these" is written in seven places</strong>: the child cascades of <code>BookingResource</code>, <code>BookingSlot</code>, <code>BookingResourceTariff</code> and <code>BookingTariffPreset</code>, the order's bookings in <code>BookingHooks::yoyakuTransactionPredelete()</code>, and the grant purges of D3.</li> <li><strong>The refusal "still has records (type: n, type: n)" is built three times</strong>: <code>ReferencingRecords::refuseDeletionWhileNamed()</code>, <code>BookingResource::preDelete()</code> and <code>Tenant::preDelete()</code>.</li> <li><strong>Ten entity getters re-implement <code>EntityIntegerValueTrait::getIntegerValue()</code></strong>: the order's hold times, the slot's start, end and opening, the allotments' release, the order's archive time and the place's position.</li> <li><strong>The booking operations are mapped to the booking manager three times</strong>: <code>BookingsForm::getCoreActions()</code>, <code>BookingOverviewForm</code> and <code>BookingOperationController::run()</code>.</li> <li><strong>An order's bookings are queried by hand beside <code>TransactionLookup::getBookings()</code></strong>, in <code>LocalBookingClient::buildOrderArray()</code> and <code>BookingHooks::yoyakuTransactionPredelete()</code>.</li> </ul> <h3>Proposed resolution</h3> <p>Give each computation one owner and call it from every place, correct the three names, and rewrite the resource type page as a description of what exists. Regenerate docs/metrics.md last.</p> <h3>Remaining tasks</h3> <p>Write the merge request.</p> <h3>User interface changes</h3> <p>Every allotment screen says the release lead as "@interval before each slot". The resource and preset allotment lists said "before the slot".</p> <h3>API changes</h3> <p><code>BookingManagerInterface</code> gains <code>applyOperation()</code>, which matches a booking operation name to its method. <code>PlaceTariffMatcher::getGradeIds()</code> is static. <code>PlacementPartitions</code> and <code>VenuePlacementProvider</code> no longer take the tariff matcher, and <code>LocalBookingClient</code> and the <code>ResourceManagers</code> audience take the transaction lookup.</p> <p>AI-Generated: Yes (Claude Code was used to run this audit and draft this issue. I reviewed it before posting.)</p>