Skip to content

GitLab

Commit b91b15e9 authored by Dave Reid's avatar Dave Reid
Browse files

by Dave Reid: Convert taxonomy term bundles from vid to machine_name.

parent c6494717
Hide whitespace changes
Inline Side-by-side
xmlsitemap.admin.inc
View file @ b91b15e9
......@@ -551,6 +551,17 @@ function xmlsitemap_add_form_entity_summary(&$form, $entity, array $entity_info)
*/
function xmlsitemap_add_link_bundle_settings(array &$form, array &$form_state, $entity, $bundle) {
$entity_info = xmlsitemap_get_link_info($entity);
//if (!isset($bundle) && isset($entity_info['bundle keys']['bundle'])) {
// $bundle_key = $entity_info['bundle keys']['bundle'];
// if (isset($form[$bundle_key]['#value'])) {
// $bundle = $form[$bundle_key]['#value'];
// }
// elseif (isset($form[$bundle_key]['#default_value'])) {
// $bundle = $form[$bundle_key]['#default_value'];
// }
//}
$bundle_info = xmlsitemap_link_bundle_load($entity, $bundle);
$form['xmlsitemap'] = array(
......@@ -644,22 +655,6 @@ function xmlsitemap_link_bundle_settings_form(array $form, array &$form_state, a
return $form;
}
function xmlsitemap_link_bundle_settings_form_submit($form, &$form_state) {
$entity = $form['xmlsitemap']['#entity'];
$bundle = $form['xmlsitemap']['#bundle'];
xmlsitemap_link_bundle_settings_save($entity, $bundle, $form_state['values']['xmlsitemap']);
$entity_info = $form['xmlsitemap']['#entity_info'];
if (!empty($form['xmlsitemap']['#show_message'])) {
drupal_set_message(t('XML sitemap settings for the @bundle-label %bundle have been saved.', array('@bundle-label' => drupal_strtolower($entity_info['bundle label']), '%bundle' => $entity_info['bundles'][$bundle]['label'])));
}
// Unset the form values since we have already saved the bundle settings and
// we don't want these values to get saved as variables in-case this form
// also uses system_settings_form().
unset($form_state['values']['xmlsitemap']);
}
/**
* Add a link's XML sitemap options to the link's form.
*
......
xmlsitemap.module
View file @ b91b15e9
......@@ -865,12 +865,21 @@ function xmlsitemap_get_link_type_indexed_status($entity_type, $bundle = '') {
$status['indexed'] = $indexed->countQuery()->execute()->fetchField();
$status['visible'] = $visible->countQuery()->execute()->fetchField();
$total = db_select($info['base table']);
$total->addField($info['base table'], $info['entity keys']['id']);
$total = db_select($info['base table'], 'base');
$total->addField('base', $info['entity keys']['id']);
$total->condition($info['entity keys']['id'], 0, '>');
if (!empty($info['entity keys']['bundle'])) {
if (!empty($info['bundle keys']['bundle'])) {
$total->condition($info['bundle keys']['bundle'], $bundle);
}
elseif (!empty($info['entity keys']['bundle'])) {
$total->condition($info['entity keys']['bundle'], $bundle);
}
$total->addTag('xmlsitemap_link_index_count');
$total->addMetaData('entity', $entity_type);
$total->addMetaData('bundle', $bundle);
$total->addMetaData('entity_info', $info);
$status['total'] = $total->countQuery()->execute()->fetchField();
return $status;
......@@ -908,7 +917,9 @@ function xmlsitemap_link_bundle_load($entity, $bundle, $load_bundle_info = TRUE)
);
if ($load_bundle_info) {
$entity_info = xmlsitemap_get_link_info($entity);
$info['info'] = $entity_info['bundles'][$bundle];
if (isset($entity_info['bundles'][$bundle])) {
$info['info'] = $entity_info['bundles'][$bundle];
}
}
$info += variable_get("xmlsitemap_settings_{$entity}_{$bundle}", array());
$info += array(
......@@ -1165,6 +1176,36 @@ function xmlsitemap_process_form_link_options($form, &$form_state) {
}
}
function xmlsitemap_link_bundle_settings_form_submit($form, &$form_state) {
$entity = $form['xmlsitemap']['#entity'];
$bundle = $form['xmlsitemap']['#bundle'];
// Handle new bundles by fetching the proper bundle key value from the form
// state values.
if (empty($bundle)) {
$entity_info = $form['xmlsitemap']['#entity_info'];
if (isset($entity_info['bundle keys']['bundle'])) {
$bundle_key = $entity_info['bundle keys']['bundle'];
if (isset($form_state['values'][$bundle_key])) {
$bundle = $form_state['values'][$bundle_key];
$form['xmlsitemap']['#bundle'] = $bundle;
}
}
}
xmlsitemap_link_bundle_settings_save($entity, $bundle, $form_state['values']['xmlsitemap']);
$entity_info = $form['xmlsitemap']['#entity_info'];
if (!empty($form['xmlsitemap']['#show_message'])) {
drupal_set_message(t('XML sitemap settings for the @bundle-label %bundle have been saved.', array('@bundle-label' => drupal_strtolower($entity_info['bundle label']), '%bundle' => $entity_info['bundles'][$bundle]['label'])));
}
// Unset the form values since we have already saved the bundle settings and
// we don't want these values to get saved as variables in-case this form
// also uses system_settings_form().
unset($form_state['values']['xmlsitemap']);
}
/**
* @todo Document this function.
* @todo Make these translatable
......
xmlsitemap_taxonomy/xmlsitemap_taxonomy.install
View file @ b91b15e9
......@@ -12,9 +12,9 @@
function xmlsitemap_taxonomy_uninstall() {
drupal_load('module', 'taxonomy');
drupal_load('module', 'xmlsitemap');
$vids = array_keys(taxonomy_get_vocabularies());
foreach ($vids as $vid) {
xmlsitemap_link_bundle_delete('taxonomy_term', $vid);
$vocabularies = taxonomy_get_vocabularies();
foreach ($vocabularies as $vid => $vocabulary) {
xmlsitemap_link_bundle_delete('taxonomy_term', $vocabulary->machine_name);
}
}
......@@ -52,3 +52,16 @@ function xmlsitemap_taxonomy_update_6200() {
*/
function xmlsitemap_taxonomy_update_6201() {
}
/**
* Change bundles on taxonomy terms from vid to $vocabulary->machine_name.
*/
function xmlsitemap_taxonomy_update_7200() {
drupal_load('module', 'taxonomy');
drupal_load('module', 'xmlsitemap');
$vocabularies = taxonomy_get_vocabularies();
foreach ($vocabularies as $vid => $vocabulary) {
xmlsitemap_link_bundle_rename('taxonomy_term', $vid, $vocabulary->machine_name);
}
}
xmlsitemap_taxonomy/xmlsitemap_taxonomy.module
View file @ b91b15e9
......@@ -15,14 +15,10 @@ function xmlsitemap_taxonomy_entity_info_alter(&$entity_info) {
* Implements hook_xmlsitemap_link_info_alter().
*/
function xmlsitemap_taxonomy_xmlsitemap_link_info_alter(&$link_info) {
// Change taxonomy term bundle type from machine name to vid.
$link_info['taxonomy_term']['entity keys']['bundle'] = 'vid';
foreach (taxonomy_vocabulary_get_names() as $machine_name => $vocabulary) {
// Adjust the edit path to the *real* edit path.
$link_info['taxonomy_term']['bundles'][$machine_name]['admin']['path'] .= '/edit';
$link_info['taxonomy_term']['bundles'][$machine_name]['admin']['real path'] .= '/edit';
$link_info['taxonomy_term']['bundles'][$vocabulary->vid] = $link_info['taxonomy_term']['bundles'][$machine_name];
unset($link_info['taxonomy_term']['bundles'][$machine_name]);
}
}
......@@ -39,8 +35,8 @@ function xmlsitemap_taxonomy_cron() {
* Implements hook_xmlsitemap_index_links().
*/
function xmlsitemap_taxonomy_xmlsitemap_index_links($limit) {
if ($vids = xmlsitemap_get_link_type_enabled_bundles('taxonomy_term')) {
$tids = db_query_range("SELECT t.tid FROM {taxonomy_term_data} t LEFT JOIN {xmlsitemap} x ON x.type = 'taxonomy_term' AND t.tid = x.id WHERE x.id IS NULL AND t.vid IN (:vids) ORDER BY t.tid DESC", 0, $limit, array(':vids' => $vids))->fetchCol();
if ($bundles = xmlsitemap_get_link_type_enabled_bundles('taxonomy_term')) {
$tids = db_query_range("SELECT t.tid FROM {taxonomy_term_data} t INNER JOIN {taxonomy_vocabulary} tv USING (vid) LEFT JOIN {xmlsitemap} x ON x.type = 'taxonomy_term' AND t.tid = x.id WHERE x.id IS NULL AND tv.machine_name IN (:bundles) ORDER BY t.tid DESC", 0, $limit, array(':bundles' => $bundles))->fetchCol();
xmlsitemap_taxonomy_xmlsitemap_process_taxonomy_term_links($tids);
}
}
......@@ -66,10 +62,13 @@ function xmlsitemap_taxonomy_xmlsitemap_process_taxonomy_term_links(array $tids)
* @see xmlsitemap_add_link_bundle_settings()
*/
function xmlsitemap_taxonomy_form_taxonomy_form_vocabulary_alter(&$form, $form_state) {
$vid = isset($form['vid']['#value']) ? $form['vid']['#value'] : 0;
if (in_array('taxonomy_vocabulary_confirm_delete_submit', $form['#submit'])) {
// If this is the delete form, do not add our form elements.
return;
}
module_load_include('inc', 'xmlsitemap', 'xmlsitemap.admin');
xmlsitemap_add_link_bundle_settings($form, $form_state, 'taxonomy_term', $vid);
xmlsitemap_add_link_bundle_settings($form, $form_state, 'taxonomy_term', $form['#vocabulary']->machine_name);
}
/**
......@@ -83,7 +82,7 @@ function xmlsitemap_taxonomy_form_taxonomy_form_term_alter(&$form, $form_state)
// Add the link options.
module_load_include('inc', 'xmlsitemap', 'xmlsitemap.admin');
xmlsitemap_add_form_link_options($form, 'taxonomy_term', $form['vid']['#value'], $form['tid']['#value']);
xmlsitemap_add_form_link_options($form, 'taxonomy_term', $form['#term']['vocabulary_machine_name'], $form['tid']['#value']);
}
/**
......@@ -91,7 +90,7 @@ function xmlsitemap_taxonomy_form_taxonomy_form_term_alter(&$form, $form_state)
*/
function xmlsitemap_taxonomy_vocabulary_insert(stdClass $vocabulary) {
if (isset($vocabulary->xmlsitemap)) {
xmlsitemap_link_bundle_settings_save('taxonomy_term', $vocabulary->vid, $vocabulary->xmlsitemap);
xmlsitemap_link_bundle_settings_save('taxonomy_term', $vocabulary->machine_name, $vocabulary->xmlsitemap);
}
}
......@@ -100,7 +99,7 @@ function xmlsitemap_taxonomy_vocabulary_insert(stdClass $vocabulary) {
*/
function xmlsitemap_taxonomy_vocabulary_update(stdClass $vocabulary) {
if (isset($vocabulary->xmlsitemap)) {
xmlsitemap_link_bundle_settings_save('taxonomy_term', $vocabulary->vid, $vocabulary->xmlsitemap);
xmlsitemap_link_bundle_settings_save('taxonomy_term', $vocabulary->machine_name, $vocabulary->xmlsitemap);
}
}
......@@ -108,7 +107,7 @@ function xmlsitemap_taxonomy_vocabulary_update(stdClass $vocabulary) {
* Implements hook_taxonomy_vocabulary_delete().
*/
function xmlsitemap_taxonomy_vocabulary_delete(stdClass $vocabulary) {
xmlsitemap_link_bundle_delete('taxonomy_term', $vocabulary->vid);
xmlsitemap_link_bundle_delete('taxonomy_term', $vocabulary->machine_name);
}
/**
......@@ -141,7 +140,7 @@ function xmlsitemap_taxonomy_field_extra_fields() {
$extras = array();
$bundles = xmlsitemap_get_link_type_enabled_bundles('taxonomy_term');
foreach (taxonomy_vocabulary_get_names() as $machine_name => $vocabulary) {
if (!in_array($vocabulary->vid, $bundles)) {
if (!in_array($vocabulary->machine_name, $bundles)) {
continue;
}
$extras['taxonomy_term'][$machine_name]['xmlsitemap'] = array(
......@@ -169,12 +168,12 @@ function xmlsitemap_taxonomy_create_link(stdClass &$term) {
}
}
$settings = xmlsitemap_link_bundle_load('taxonomy_term', $term->vid);
$settings = xmlsitemap_link_bundle_load('taxonomy_term', $term->vocabulary_machine_name);
$term->xmlsitemap += array(
'id' => $term->tid,
'type' => 'taxonomy_term',
'subtype' => $term->vid,
'subtype' => $term->vocabulary_machine_name,
'loc' => 'taxonomy/term/' . $term->tid,
'status' => $settings['status'],
'status_default' => $settings['status'],
......@@ -242,3 +241,13 @@ function xmlsitemap_taxonomy_get_node_count(stdClass $term) {
// @todo Use db_rewrite_sql() w/ switch user.
return db_query_range("SELECT COUNT(ti.nid) FROM {taxonomy_index} ti LEFT JOIN {node n} USING (nid) WHERE ti.tid = :tid AND n.status = 1", 0, 1, array(':tid' => $term->tid))->fetchField();
}
/**
* Implements hook_query_TAG_alter().
*/
function xmlsitemap_taxonomy_query_xmlsitemap_link_index_count_alter(QueryAlterableInterface $query) {
if ($query->getMetaData('entity') == 'taxonomy_term') {
$query->innerJoin('taxonomy_vocabulary', 'v', 'base.vid = v.vid');
$query->addField('v', 'machine_name', 'vocabulary_machine_name');
}
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment