>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3625002. --> Reported by: [heddn](https://www.drupal.org/user/1463982) Related to !170 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p><code>TrackedLinkValidationTrait::validateLinks()</code> (added in #3494762 to stop a menu form save from clobbering a link that's tracked in another workspace) checks <strong>every</strong> menu link content entity present on the menu overview form, not just the ones the current submission actually changed.</p> <p>As a result, saving a menu form fails validation as soon as <em>any</em> link anywhere in the menu is tracked in another workspace &mdash; even if the user only touched an unrelated link, or made no changes to the tracked link's weight, parent, or enabled state at all. On menus shared across several open workspaces this makes the menu overview form effectively unusable: almost any save is blocked by a link someone else is working on elsewhere in the tree.</p> <p>LLM in use.</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <ol> <li>Enable Workspaces and WSE Menu. Create a menu with several links.</li> <li>In workspace A, edit one menu link's weight/parent (this tracks that link in workspace A).</li> <li>Switch to workspace B (or Live).</li> <li>Open the same menu's overview form and change the weight of a <em>different, unrelated</em> link, leaving the link tracked in workspace A untouched.</li> <li>Save the form.</li> </ol> <p>Expected: the save succeeds, since the link tracked in workspace A was not modified.</p> <p>Actual: validation fails with "Could not update menu link <em>X</em> because it's tracked in other workspaces (A)", even though link X's weight/parent/enabled values were never touched in the submitted form.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Scope <code>validateLinks()</code> to only the links that actually changed in the current submission. For each submitted link row, compare the submitted <code>weight</code>, <code>parent</code>, and <code>enabled</code> values against the form element's <code>#default_value</code>; only run the cross-workspace tracking check against links where at least one of those values differs. Links present on the form but left unmodified are skipped entirely, regardless of what workspace they're tracked in.</p> <p>This is a behavioral fix contained to <code>TrackedLinkValidationTrait::validateLinks()</code>, with corresponding call-site adjustments in <code>WseMenuForm</code> and <code>WseGroupContentMenuForm</code> so the trait has access to the form's default values for comparison.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>Write the patch/MR.</li> <li>Add test coverage (kernel or functional) exercising: unrelated link save succeeds while a tracked-but-unmodified link exists; save of the tracked link itself still correctly blocked when actually changed.</li> <li>Review.</li> </ul> <h3 id="summary-ui-changes">User interface changes</h3> <p>None. The error message and when it's legitimately triggered are unchanged; only false-positive validation failures are removed.</p> <h3 id="summary-api-changes">API changes</h3> <p>None to public API. <code>TrackedLinkValidationTrait::validateLinks()</code> is <code>protected</code>; its internal behavior changes but its signature does not.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>None.</p>