>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #1084436. --> Reported by: [binford2k](https://www.drupal.org/user/12534) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>In some cases, nodes published from moderation lose their associated files. </p> <h4 id="steps">Steps to reproduce</h4> <p>Quoted from comment <a href="https://www.drupal.org#comment-4340326">#6</a>:</p> <blockquote><p>if I attach files and publish via the "moderate" tab, then all is OK (ie files don't seem to go missing). If I publish directly after saving the draft by selecting the "publish" action from the drop down list on that page, then files start to go missing. By example:<br> 1) create draft page and attach file A - &gt; save, hit moderate tab and then publish from there (file present)<br> 2) new draft page and attach a second file (now have File A and B) -&gt; save, hit moderate and publish from there (both files present)<br> 3) new draft page and attach a third file (now have File's A, B and C) -&gt; save, hit moderate and publish from there (all three files present)</p> <p>All is OK until this point. Now we try and publish our next draft by saving and selecting publish directly from the drop down on the draft page (ie rather than going via the moderate tab):<br> 4) new draft page and attach fourth file (now A, B, C &amp; D) -&gt; save and publish from the drop down presented on the draft page directly (files now start dropping from the page).</p></blockquote> <p>A less than ideal fix was committed at <a href="https://www.drupal.org/node/1084436#comment-4581922">#35</a>: <a href="http://cgit.drupalcode.org/workbench_moderation/commit/?id=a66a37e">http://cgit.drupalcode.org/workbench_moderation/commit/?id=a66a37e</a></p> <p>comment <a href="https://www.drupal.org/node/1084436#comment-6922098">#42</a> lays out what is going on:</p> <blockquote><p> You want to save a draft with a new file and you submit the form<br> node_save gets called and a new revision gets saved and is now the new current version of the node (this is super dump and the main issue here anyway)<br> to "pull back" the revision which is actually just a draft node_save gets called again with the former "stable" version of the node.<br> $node-&gt;original = entity_load_unchanged('node', $node-&gt;nid); will pull up the "draft" as its the current "head" revision<br> file_field_update() will compare the unchanged "stable" version against the "draft" (it should compare it against the "stable" version)<br> With this screwed up perspective it looks as if the file (that was actually added to the draft) is missing in the "stable" version.<br> Therefore file_field_delete_file() gets called, the file_usage counter gets reduced, most likely to 0 and the file is dropped<br> The unchanged "stable" version gets saved and is now the most current version again. The "draft" ends up with a reference to the uploaded file, which no longer exists as it got deleted.</p></blockquote> <p>An additional related problem was reported in <a href="https://www.drupal.org/node/1084436#comment-7694745">#50</a>:</p> <blockquote><p>I'm using the file_entity and media modules and came across the issue where removing a file from a field was not removing the usage.</p> <p>I set up a vanilla environment with the same file field using the media widget on 2 content types. I set up 1 content type with revisions disabled, and the other to use workbench. The content type using workbench encountered the bug I described, but the non-revisioned type did not. I suspect this is a similar issue to what's happening with adding files. But to reproduce:</p> <p>1) Create a node and upload a file<br> 2) Save and publish the node (The file usage now reports it is in use on the same node twice).<br> 3) Create new draft, remove the file and save. File usage now reports it is in use on the node 3 times even though I just removed it.<br> 4) Publish node, file usage goes back to 2 and file is not deleted.</p></blockquote> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>The latest patch in #55 is a re-roll of #53. #53 improved upon #47 (which was RTBC by one person) by avoiding issue with <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/state_machine/-/work_items/1963992" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/state_machine/-/work_items/1963992</a></span>. This patch removes the original "brute force" sub-optimal solution that was previously committed.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <p>Review &amp; test latest patch. Need to confirm or deny the concerns mentioned in <a href="https://www.drupal.org/node/1084436#comment-9007239">#54</a>.</p>