Commit ac10c438 authored by Eirik Morland's avatar Eirik Morland
Browse files

Issue #3255195 by eiriksm: Avoid logging empty Sha log messages

parent 80d98eca
Loading
Loading
Loading
Loading
+4 −4
Original line number Diff line number Diff line
@@ -244,15 +244,15 @@ class NeedsUpdateManager {
          throw new NeedsUpdateException("No sha stored for package $dep");
        }
        $current_package_sha = $this->getNewShaForPackage($dep, $composer_json, $env, $auth_json);
        $this->logger->info('Current package sha for package @package is @sha', [
          '@package' => $dep,
          '@sha' => $current_package_sha,
        ]);
        if (FALSE === $current_package_sha) {
          // Some error prevented us from finding the sha, We do not want to
          // store that, so we keep on checking other packages.
          continue;
        }
        $this->logger->info('Current package sha for package @package is @sha', [
          '@package' => $dep,
          '@sha' => $current_package_sha,
        ]);
        if ($sha->getSha() != $current_package_sha) {
          // Run update.
          $new_sha = new UpdateCheckSha($current_package_sha, time());