Commit 11469c52 authored by Diwakar Sah's avatar Diwakar Sah Committed by Steven Jones
Browse files

Issue #2922153 by Steven Jones, Spokje, Diwakar07, SivaprasadC, phjou, sarguna... 

Issue #2922153 by Steven Jones, Spokje, Diwakar07, SivaprasadC, phjou, sarguna raj M, roshni27, manish-31, jhedstrom: Fix coding standards messages
parent a1687aea

.gitlab-ci.yml

+3 −4
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ include: 
# https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes/include.drupalci.variables.yml

# Uncomment the lines below if you want to override any of the variables. The following is just an example.

################

# variables:

#   SKIP_ESLINT: '1'

#   OPT_IN_TEST_NEXT_MAJOR: '1'

#   _CURL_TEMPLATES_REF: 'main'
 
variables:

  # CSpell was picking up too many false positives, so disable.

  SKIP_CSPELL: '1'

css/views_data_export.css

+4 −4
Original line number Diff line number Diff line
@@ -2,11 +2,11 @@ 
  display: inline;

}

.views-data-export-feed .feed-icon {

  background: no-repeat;

  overflow: hidden;

  text-indent: -9999px;

  display: block;

  overflow: hidden;

  width: 36px;

  text-indent: -9999px;

  background: no-repeat;

}

.json-feed .feed-icon {

  background-image: url(../images/json.png);
@@ -21,6 +21,6 @@ 
  background-image: url(../images/xls.png);

}

.xlsx-feed .feed-icon {

  background-image: url(../images/xlsx.png);

  width: 43px;

  background-image: url(../images/xlsx.png);

}

js/views_data_export_auto_download.js

+9 −5
Original line number Diff line number Diff line
@@ -5,13 +5,17 @@ 
 */

(function (Drupal, once) {

  Drupal.behaviors.views_data_export_auto_download = {

    attach: function () {

      once('vde-automatic-download', '#vde-automatic-download').forEach(function (link) {

    attach(context) {

      once(

        'vde-automatic-download',

        '#vde-automatic-download',

        context,

      ).forEach(function (link) {

        link.focus();

        if (link.dataset.downloadEnabled === 'true') {

          location.href = link.href;

        }

      })

          window.location.href = link.href;

        }

      });

    },

  };

})(Drupal, once);

phpstan-baseline.neon

0 → 100644
+21 −0
Original line number Diff line number Diff line 
parameters:

	ignoreErrors:

		-

			message: """

				#^Call to deprecated method setCellValueByColumnAndRow\\(\\) of class PhpOffice\\\\PhpSpreadsheet\\\\Worksheet\\\\Worksheet\\:

				1\\.23\\.0

				     Use the setCellValue\\(\\) method with a cell address such as 'C5' instead;,

				         or passing in an array of \\[\\$columnIndex, \\$row\\] \\(e\\.g\\. \\[3, 5\\]\\), or a CellAddress object\\.$#

			"""

			count: 1

			path: src/Plugin/views/display/DataExport.php



		-

			message: "#^\\\\Drupal calls should be avoided in classes, use dependency injection instead$#"

			count: 5

			path: src/Plugin/views/display/DataExport.php



		-

			message: "#^\\\\Drupal calls should be avoided in classes, use dependency injection instead$#"

			count: 1

			path: src/Plugin/views/style/DataExport.php

src/Plugin/views/display/DataExport.php

+6 −6
Original line number Diff line number Diff line
@@ -5,18 +5,18 @@ namespace Drupal\views_data_export\Plugin\views\display; 
use Drupal\Core\Cache\CacheableMetadata;

use Drupal\Core\Cache\CacheableResponse;

use Drupal\Core\Config\StorageException;

use Drupal\Core\File\FileSystemInterface;

use Drupal\Core\Form\FormStateInterface;

use Drupal\Core\Render\BubbleableMetadata;

use Drupal\rest\Plugin\views\display\RestExport;

use Drupal\views\Views;

use Drupal\views\ViewExecutable;

use Drupal\Core\Url;

use Symfony\Component\HttpFoundation\RedirectResponse;

use Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException;

use Drupal\rest\Plugin\views\display\RestExport;

use Drupal\search_api\Plugin\views\query\SearchApiQuery;

use Drupal\views\ViewExecutable;

use Drupal\views\Views;

use PhpOffice\PhpSpreadsheet\IOFactory;

use PhpOffice\PhpSpreadsheet\Writer\Xlsx;

use Drupal\Core\File\FileSystemInterface;

use Symfony\Component\HttpFoundation\RedirectResponse;

use Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException;



/**

 * Provides a data export display plugin.