Loading .eslintrc.json 0 → 100644 +95 −0 Original line number Diff line number Diff line { "extends": "eslint:recommended", "root": true, "env": { "browser": true }, "globals": { "Drupal": true, "drupalSettings": true, "drupalTranslations": true, "domready": true, "jQuery": true, "_": true, "matchMedia": true, "Backbone": true, "Modernizr": true, "CKEDITOR": true, "once": true }, "rules": { "array-bracket-spacing": ["error", "never"], "block-scoped-var": "error", "brace-style": ["error", "stroustrup", {"allowSingleLine": true}], "comma-dangle": ["error", "never"], "comma-spacing": "error", "comma-style": ["error", "last"], "computed-property-spacing": ["error", "never"], "curly": ["error", "all"], "eol-last": "error", "eqeqeq": ["error", "smart"], "guard-for-in": "error", "indent": ["error", 2, {"SwitchCase": 1}], "key-spacing": ["error", {"beforeColon": false, "afterColon": true}], "keyword-spacing": ["error", {"before": true, "after": true}], "linebreak-style": ["error", "unix"], "lines-around-comment": ["error", {"beforeBlockComment": true, "afterBlockComment": false}], "new-parens": "error", "no-array-constructor": "error", "no-caller": "error", "no-catch-shadow": "error", "no-eval": "error", "no-extend-native": "error", "no-extra-bind": "error", "no-extra-parens": ["error", "functions"], "no-implied-eval": "error", "no-iterator": "error", "no-label-var": "error", "no-labels": "error", "no-lone-blocks": "error", "no-loop-func": "error", "no-multi-spaces": "error", "no-multi-str": "error", "no-native-reassign": "error", "no-nested-ternary": "error", "no-new-func": "error", "no-new-object": "error", "no-new-wrappers": "error", "no-octal-escape": "error", "no-process-exit": "error", "no-proto": "error", "no-return-assign": "error", "no-script-url": "error", "no-sequences": "error", "no-shadow-restricted-names": "error", "no-spaced-func": "error", "no-trailing-spaces": "error", "no-undef-init": "error", "no-undefined": "error", "no-unused-expressions": "error", "no-unused-vars": ["error", {"vars": "all", "args": "none"}], "no-with": "error", "object-curly-spacing": ["error", "never"], "one-var": ["error", "never"], "quote-props": ["error", "consistent-as-needed"], "quotes": ["error", "single", "avoid-escape"], "semi": ["error", "always"], "semi-spacing": ["error", {"before": false, "after": true}], "space-before-blocks": ["error", "always"], "space-before-function-paren": ["error", {"anonymous": "always", "named": "never"}], "space-in-parens": ["error", "never"], "space-infix-ops": "error", "space-unary-ops": ["error", { "words": true, "nonwords": false }], "spaced-comment": ["error", "always"], "strict": ["error", "function"], "yoda": ["error", "never"], "max-nested-callbacks": ["warn", 3], "valid-jsdoc": ["warn", { "prefer": { "returns": "return", "property": "prop" }, "requireReturn": false }] } } js/frontUi.js +8 −8 Original line number Diff line number Diff line Loading @@ -98,22 +98,23 @@ * @param {string} value */ update(state, index, value) { if (value === undefined) { if (typeof value === 'undefined') { value = null; } if (this.view_id.length && this.display_id.length) { // TODO: prevent form submission when ajaxing. var selectionObject = this; var list = {}, op = ''; var list = {}; var op = ''; if (index === 'selection_method_change') { var op = state ? 'method_exclude' : 'method_include'; op = state ? 'method_exclude' : 'method_include'; if (state) { list = this.list[index]; } } else { if (value && value != 'on') { if (value && value !== 'on') { list[value] = this.list[index][value]; } else { Loading Loading @@ -157,7 +158,6 @@ $viewsTables.each(function (index) { tableSelectAll[index] = $vboForm.find('.select-all input').first(); }); var $tableSelectAll = $(tableSelectAll); } // Add AJAX functionality to row selector checkboxes. Loading Loading @@ -186,7 +186,7 @@ $contentWrapper.find('.views-field-views-bulk-operations-bulk-form input[type="checkbox"]').each(function () { var value = $(this).val(); if (value != 'on') { if (value !== 'on') { vboSelection.list[index][value] = value; vboSelection.bindEventHandlers($(this), index); } Loading @@ -209,7 +209,7 @@ // If there are table select all elements, use that. if (tableSelectAll.length) { tableSelectAll.forEach(function (element) { if (element.get(0).checked != value) { if (element.get(0).checked !== value) { element.click(); } }); Loading @@ -217,7 +217,7 @@ // Also handle checkboxes that may still have different values. $vboForm.find('.views-field-views-bulk-operations-bulk-form input[type="checkbox"]').each(function () { if (this.checked != value) { if (this.checked !== value) { $(this).click(); } }); Loading tests/src/FunctionalJavascript/ViewsBulkOperationsBulkFormTest.php +1 −1 Original line number Diff line number Diff line <?php namespace Drupal\Tests\views_bulk_operations\FunctionalJavaScript; namespace Drupal\Tests\views_bulk_operations\FunctionalJavascript; use Behat\Mink\Element\DocumentElement; use Drupal\FunctionalJavascriptTests\WebDriverTestBase; Loading Loading
.eslintrc.json 0 → 100644 +95 −0 Original line number Diff line number Diff line { "extends": "eslint:recommended", "root": true, "env": { "browser": true }, "globals": { "Drupal": true, "drupalSettings": true, "drupalTranslations": true, "domready": true, "jQuery": true, "_": true, "matchMedia": true, "Backbone": true, "Modernizr": true, "CKEDITOR": true, "once": true }, "rules": { "array-bracket-spacing": ["error", "never"], "block-scoped-var": "error", "brace-style": ["error", "stroustrup", {"allowSingleLine": true}], "comma-dangle": ["error", "never"], "comma-spacing": "error", "comma-style": ["error", "last"], "computed-property-spacing": ["error", "never"], "curly": ["error", "all"], "eol-last": "error", "eqeqeq": ["error", "smart"], "guard-for-in": "error", "indent": ["error", 2, {"SwitchCase": 1}], "key-spacing": ["error", {"beforeColon": false, "afterColon": true}], "keyword-spacing": ["error", {"before": true, "after": true}], "linebreak-style": ["error", "unix"], "lines-around-comment": ["error", {"beforeBlockComment": true, "afterBlockComment": false}], "new-parens": "error", "no-array-constructor": "error", "no-caller": "error", "no-catch-shadow": "error", "no-eval": "error", "no-extend-native": "error", "no-extra-bind": "error", "no-extra-parens": ["error", "functions"], "no-implied-eval": "error", "no-iterator": "error", "no-label-var": "error", "no-labels": "error", "no-lone-blocks": "error", "no-loop-func": "error", "no-multi-spaces": "error", "no-multi-str": "error", "no-native-reassign": "error", "no-nested-ternary": "error", "no-new-func": "error", "no-new-object": "error", "no-new-wrappers": "error", "no-octal-escape": "error", "no-process-exit": "error", "no-proto": "error", "no-return-assign": "error", "no-script-url": "error", "no-sequences": "error", "no-shadow-restricted-names": "error", "no-spaced-func": "error", "no-trailing-spaces": "error", "no-undef-init": "error", "no-undefined": "error", "no-unused-expressions": "error", "no-unused-vars": ["error", {"vars": "all", "args": "none"}], "no-with": "error", "object-curly-spacing": ["error", "never"], "one-var": ["error", "never"], "quote-props": ["error", "consistent-as-needed"], "quotes": ["error", "single", "avoid-escape"], "semi": ["error", "always"], "semi-spacing": ["error", {"before": false, "after": true}], "space-before-blocks": ["error", "always"], "space-before-function-paren": ["error", {"anonymous": "always", "named": "never"}], "space-in-parens": ["error", "never"], "space-infix-ops": "error", "space-unary-ops": ["error", { "words": true, "nonwords": false }], "spaced-comment": ["error", "always"], "strict": ["error", "function"], "yoda": ["error", "never"], "max-nested-callbacks": ["warn", 3], "valid-jsdoc": ["warn", { "prefer": { "returns": "return", "property": "prop" }, "requireReturn": false }] } }
js/frontUi.js +8 −8 Original line number Diff line number Diff line Loading @@ -98,22 +98,23 @@ * @param {string} value */ update(state, index, value) { if (value === undefined) { if (typeof value === 'undefined') { value = null; } if (this.view_id.length && this.display_id.length) { // TODO: prevent form submission when ajaxing. var selectionObject = this; var list = {}, op = ''; var list = {}; var op = ''; if (index === 'selection_method_change') { var op = state ? 'method_exclude' : 'method_include'; op = state ? 'method_exclude' : 'method_include'; if (state) { list = this.list[index]; } } else { if (value && value != 'on') { if (value && value !== 'on') { list[value] = this.list[index][value]; } else { Loading Loading @@ -157,7 +158,6 @@ $viewsTables.each(function (index) { tableSelectAll[index] = $vboForm.find('.select-all input').first(); }); var $tableSelectAll = $(tableSelectAll); } // Add AJAX functionality to row selector checkboxes. Loading Loading @@ -186,7 +186,7 @@ $contentWrapper.find('.views-field-views-bulk-operations-bulk-form input[type="checkbox"]').each(function () { var value = $(this).val(); if (value != 'on') { if (value !== 'on') { vboSelection.list[index][value] = value; vboSelection.bindEventHandlers($(this), index); } Loading @@ -209,7 +209,7 @@ // If there are table select all elements, use that. if (tableSelectAll.length) { tableSelectAll.forEach(function (element) { if (element.get(0).checked != value) { if (element.get(0).checked !== value) { element.click(); } }); Loading @@ -217,7 +217,7 @@ // Also handle checkboxes that may still have different values. $vboForm.find('.views-field-views-bulk-operations-bulk-form input[type="checkbox"]').each(function () { if (this.checked != value) { if (this.checked !== value) { $(this).click(); } }); Loading
tests/src/FunctionalJavascript/ViewsBulkOperationsBulkFormTest.php +1 −1 Original line number Diff line number Diff line <?php namespace Drupal\Tests\views_bulk_operations\FunctionalJavaScript; namespace Drupal\Tests\views_bulk_operations\FunctionalJavascript; use Behat\Mink\Element\DocumentElement; use Drupal\FunctionalJavascriptTests\WebDriverTestBase; Loading