Commit 1617c51c authored by Rajab Natshah's avatar Rajab Natshah 💬
Browse files

Issue #3269723: Switch from deprecated Node Sass to Dart Sass compiler using... 

Issue #3269723: Switch from deprecated Node Sass to Dart Sass compiler using Gulp in the Varbase Theme (Bootstrap 4 - SASS)
parent fb118d6a

.browserslistrc

deleted100644 → 0
+0 −12
Original line number Diff line number Diff line 
# https://github.com/browserslist/browserslist#readme



> 1%

chrome >= 35

firefox >= 38

edge >= 12

ie >= 10

ios >= 8

safari >= 8

android 2.3

android >= 4

opera >= 12
 
 No newline at end of file

.eslintrc.json

+9 −14
Original line number Diff line number Diff line 
{

  "extends": [

    "airbnb",

    "plugin:react/recommended",

    "airbnb-base",

    "plugin:prettier/recommended",

    "plugin:yml/recommended"

  ],

  "root": true,

  "env": {

    "browser": true

    "browser": true,

    "es6": true,

    "node": true

  },

  "globals": {

    "Drupal": true,

    "drupalSettings": true,

    "drupalTranslations": true,

    "domready": true,

    "jQuery": true,

    "_": true,

    "matchMedia": true,

    "Cookies": true,

    "Backbone": true,

    "Modernizr": true,

    "loadjs": true,

    "Popper": true,

    "Shepherd": true,

    "Sortable": true,

    "once": true,

    "CKEDITOR": true,

    "CKEditor5": true,

    "tabbable": true

  },

  "settings": {

    "react": {

      "version": "latest"

    }

  },

  "rules": {

    "prettier/prettier": ["error", {

      "trailingComma": "none"

    }],

    "prettier/prettier": "error",

    "consistent-return": ["off"],

    "no-underscore-dangle": ["off"],

    "max-nested-callbacks": ["warn", 3],

.phpcs.xml

+58 −20
Original line number Diff line number Diff line
@@ -23,7 +23,9 @@ 
  <rule ref="Drupal.Classes.ClassFileName"/>

  <rule ref="Drupal.Classes.FullyQualifiedNamespace"/>

  <rule ref="Drupal.Classes.InterfaceName"/>

  <rule ref="Drupal.Classes.PropertyDeclaration"/>

  <rule ref="Drupal.Classes.UnusedUseStatement"/>

  <rule ref="Drupal.Classes.UseGlobalClass"/>

  <rule ref="Drupal.Classes.UseLeadingBackslash"/>

  <rule ref="Drupal.CSS.ClassDefinitionNameSpacing"/>

  <rule ref="Drupal.CSS.ColourDefinition"/>
@@ -31,55 +33,50 @@ 
    <exclude name="Drupal.Commenting.ClassComment.Missing"/>

  </rule>

  <rule ref="Drupal.Commenting.DataTypeNamespace"/>

  <rule ref="Drupal.Commenting.Deprecated"/>

  <rule ref="Drupal.Commenting.DocComment">

    <!-- Sniff for these errors: SpacingAfterTagGroup, WrongEnd, SpacingBetween,

      ContentAfterOpen, SpacingBeforeShort, TagValueIndent, ShortStartSpace,

      SpacingAfter, LongNotCapital -->

      SpacingAfter, LongNotCapital, ShortFullStop, TagGroupSpacing, Empty,

      TagsNotGrouped, ParamGroup -->

    <!-- ParamNotFirst still not decided for PHPUnit-based tests.

      @see https://www.drupal.org/node/2253915 -->

    <exclude name="Drupal.Commenting.DocComment.ParamNotFirst"/>

    <exclude name="Drupal.Commenting.DocComment.SpacingBeforeTags"/>

    <exclude name="Drupal.Commenting.DocComment.LongFullStop"/>

    <exclude name="Drupal.Commenting.DocComment.ShortNotCapital"/>

    <exclude name="Drupal.Commenting.DocComment.ShortFullStop"/>

    <!-- TagsNotGrouped and ParamGroup have false-positives.

      @see https://www.drupal.org/node/2060925 -->

    <exclude name="Drupal.Commenting.DocComment.TagsNotGrouped"/>

    <exclude name="Drupal.Commenting.DocComment.ParamGroup"/>

    <exclude name="Drupal.Commenting.DocComment.ShortSingleLine"/>

    <exclude name="Drupal.Commenting.DocComment.MissingShort"/>

  </rule>

  <rule ref="Drupal.Commenting.DocCommentAlignment"/>

  <rule ref="Drupal.Commenting.DocCommentStar"/>

  <rule ref="Drupal.Commenting.FileComment"/>

  <rule ref="Drupal.Commenting.FunctionComment">

    <exclude name="Drupal.Commenting.FunctionComment.IncorrectTypeHint"/>

    <exclude name="Drupal.Commenting.FunctionComment.InvalidNoReturn"/>

    <exclude name="Drupal.Commenting.FunctionComment.InvalidTypeHint"/>

    <exclude name="Drupal.Commenting.FunctionComment.Missing"/>

    <exclude name="Drupal.Commenting.FunctionComment.MissingParamComment"/>

    <exclude name="Drupal.Commenting.FunctionComment.MissingParamType"/>

    <exclude name="Drupal.Commenting.FunctionComment.MissingReturnComment"/>

    <exclude name="Drupal.Commenting.FunctionComment.MissingReturnType"/>

    <exclude name="Drupal.Commenting.FunctionComment.ParamCommentFullStop"/>

    <exclude name="Drupal.Commenting.FunctionComment.ParamMissingDefinition"/>

    <exclude name="Drupal.Commenting.FunctionComment.TypeHintMissing"/>

  </rule>

  <rule ref="Drupal.Commenting.HookComment"/>

  <rule ref="Drupal.Commenting.GenderNeutralComment"/>

  <rule ref="Drupal.Commenting.InlineVariableComment"/>

  <rule ref="Drupal.Commenting.VariableComment">

    <!-- Sniff for: DuplicateVar, EmptyVar, InlineVariableName -->

    <!-- Sniff for: DuplicateVar, EmptyVar, InlineVariableName, WrongStyle -->

    <exclude name="Drupal.Commenting.VariableComment.IncorrectVarType"/>

    <exclude name="Drupal.Commenting.VariableComment.Missing"/>

    <exclude name="Drupal.Commenting.VariableComment.MissingVar"/>

    <exclude name="Drupal.Commenting.VariableComment.VarOrder"/>

    <exclude name="Drupal.Commenting.VariableComment.WrongStyle"/>

  </rule>

  <rule ref="Drupal.Commenting.InlineComment">

    <!-- Sniff for: NoSpaceBefore, WrongStyle -->

    <!-- Sniff for: NoSpaceBefore, SpacingBefore, WrongStyle -->

    <exclude name="Drupal.Commenting.InlineComment.DocBlock"/>

    <exclude name="Drupal.Commenting.InlineComment.InvalidEndChar"/>

    <exclude name="Drupal.Commenting.InlineComment.NotCapital"/>

    <exclude name="Drupal.Commenting.InlineComment.SpacingAfter"/>

    <exclude name="Drupal.Commenting.InlineComment.SpacingBefore"/>

  </rule>

  <rule ref="Drupal.Commenting.PostStatementComment"/>

  <rule ref="Drupal.ControlStructures.ElseIf"/>
@@ -112,12 +109,12 @@ 
  <rule ref="Drupal.Semantics.FunctionAlias"/>

  <rule ref="Drupal.Semantics.FunctionT">

    <exclude name="Drupal.Semantics.FunctionT.NotLiteralString"/>

    <exclude name="Drupal.Semantics.FunctionT.ConcatString"/>

  </rule>

  <rule ref="Drupal.Semantics.FunctionWatchdog"/>

  <rule ref="Drupal.Semantics.InstallHooks"/>

  <rule ref="Drupal.Semantics.LStringTranslatable"/>

  <rule ref="Drupal.Semantics.PregSecurity"/>

  <rule ref="Drupal.Semantics.RemoteAddress"/>

  <rule ref="Drupal.Semantics.TInHookMenu"/>

  <rule ref="Drupal.Semantics.TInHookSchema"/>

  <rule ref="Drupal.Strings.UnnecessaryStringConcat"/>
@@ -135,12 +132,14 @@ 
  <!-- Drupal Practice sniffs -->

  <rule ref="DrupalPractice.Commenting.ExpectedException"/>

  <rule ref="DrupalPractice.General.ExceptionT"/>

  <rule ref="DrupalPractice.InfoFiles.NamespacedDependency"/>



  <!-- Generic sniffs -->

  <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>

  <rule ref="Generic.CodeAnalysis.EmptyPHPStatement"/>

  <rule ref="Generic.Files.ByteOrderMark"/>

  <rule ref="Generic.Files.LineEndings"/>

  <rule ref="Generic.Formatting.DisallowMultipleStatements"/>

  <rule ref="Generic.Formatting.SpaceAfterCast"/>

  <rule ref="Generic.Functions.FunctionCallArgumentSpacing"/>

  <rule ref="Generic.Functions.OpeningFunctionBraceKernighanRitchie">
@@ -148,6 +147,8 @@ 
      <property name="checkClosures" value="true"/>

    </properties>

  </rule>

  <rule ref="Drupal.NamingConventions.ValidClassName"/>

  <rule ref="Drupal.NamingConventions.ValidGlobal"/>

  <rule ref="Generic.NamingConventions.ConstructorName"/>

  <rule ref="Generic.NamingConventions.UpperCaseConstantName"/>

  <rule ref="Generic.PHP.DeprecatedFunctions"/>
@@ -213,12 +214,12 @@ 


  <!-- PSR-2 sniffs -->

  <rule ref="PSR2.Classes.PropertyDeclaration">

     <!-- Silence method name underscore warning which is covered already in

       Drupal.Classes.PropertyDeclaration. -->

    <exclude name="PSR2.Classes.PropertyDeclaration.Underscore"/>

  </rule>

  <rule ref="PSR2.Namespaces.NamespaceDeclaration"/>

  <rule ref="PSR2.Namespaces.UseDeclaration">

    <exclude name="PSR2.Namespaces.UseDeclaration.UseAfterNamespace"/>

  </rule>

  <rule ref="PSR2.Namespaces.UseDeclaration"/>



  <!-- Squiz sniffs -->

  <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
@@ -279,6 +280,41 @@ 
  <rule ref="Squiz.ControlStructures.ForLoopDeclaration.SpacingBeforeClose">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration"/>

  <!-- Disable some error messages that we do not want. -->

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.BreakIndent">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.CaseIndent">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.CloseBraceAlign">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.DefaultIndent">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.DefaultNoBreak">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.EmptyCase">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.EmptyDefault">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.MissingDefault">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.SpacingAfterCase">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.SpacingAfterDefaultBreak">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.ControlStructures.SwitchDeclaration.SpacingBeforeBreak">

    <severity>0</severity>

  </rule>

  <rule ref="Squiz.Functions.MultiLineFunctionDeclaration"/>

  <rule ref="Squiz.Functions.MultiLineFunctionDeclaration.BraceOnSameLine">

    <severity>0</severity>
@@ -305,6 +341,7 @@ 
    <severity>0</severity>

  </rule>

  <rule ref="Squiz.PHP.LowercasePHPFunctions"/>

  <rule ref="Squiz.PHP.NonExecutableCode"/>

  <rule ref="Squiz.Strings.ConcatenationSpacing">

    <properties>

      <property name="spacing" value="1"/>
@@ -322,6 +359,7 @@ 
      <property name="ignoreNewlines" value="true"/>

    </properties>

  </rule>

  <rule ref="Squiz.WhiteSpace.ScopeKeywordSpacing"/>

  <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>

  <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace"/>

VARTHEME_BS4_SUBTHEME/.browserslistrc

deleted100644 → 0
+0 −12
Original line number Diff line number Diff line 
# https://github.com/browserslist/browserslist#readme



> 1%

chrome >= 35

firefox >= 38

edge >= 12

ie >= 10

ios >= 8

safari >= 8

android 2.3

android >= 4

opera >= 12
 
 No newline at end of file

VARTHEME_BS4_SUBTHEME/.eslintrc.json

+8 −13
Original line number Diff line number Diff line 
{

  "extends": [

    "airbnb",

    "plugin:react/recommended",

    "airbnb-base",

    "plugin:prettier/recommended",

    "plugin:yml/recommended"

  ],

  "root": true,

  "env": {

    "browser": true

    "browser": true,

    "es6": true,

    "node": true

  },

  "globals": {

    "Drupal": true,

    "drupalSettings": true,

    "drupalTranslations": true,

    "domready": true,

    "jQuery": true,

    "_": true,

    "matchMedia": true,

    "Cookies": true,

    "Backbone": true,

    "Modernizr": true,

    "loadjs": true,

    "Popper": true,

    "Shepherd": true,

    "Sortable": true,

    "once": true,

    "CKEDITOR": true,

    "CKEditor5": true,

    "tabbable": true

  },

  "settings": {

    "react": {

      "version": "latest"

    }

  },

  "rules": {

    "prettier/prettier": ["error", {

      "trailingComma": "none"

    }],

    "prettier/prettier": "error",

    "consistent-return": ["off"],

    "no-underscore-dangle": ["off"],

    "max-nested-callbacks": ["warn", 3],