Commit 8bd0c4c8 authored by Gábor Hojtsy's avatar Gábor Hojtsy
Browse files

Issue #3260723 by Liam Morland, pmagunia, Gábor Hojtsy: Quotes are escaped in...

Issue #3260723 by Liam Morland, pmagunia, Gábor Hojtsy: Quotes are escaped in list of invalid permissions
parent 8266a39f
Loading
Loading
Loading
Loading
+4 −2
Changes for src/Form/UpgradeStatusForm.php: 4 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -824,7 +824,7 @@ MARKUP
        if (!empty($invalid_role_permissions)) {
          $class = 'known-error';
          $status = FALSE;
          $requirement = [$this->t('"@permissions" of user role: "@role".', ['@permissions' => implode('", "', $invalid_role_permissions), '@role' => $role->label()])];
          $requirement = [$this->t('Permissions of user role: "@role":', ['@role' => $role->label()]) . '<ul><li>' . implode('</li><li>', $invalid_role_permissions) . '</li></ul>'];
        }
      }
      $build['data']['#rows'][] = [
@@ -835,7 +835,9 @@ MARKUP
            'data' => $this->t('<a href=":url">Invalid permissions will trigger runtime exceptions in Drupal 10.</a> Permissions should be defined in a permissions.yml file or a permission callback.', [':url' => 'https://www.drupal.org/node/3193348']),
          ],
          'status' => [
            'data' => join(' ', $requirement),
            'data' => [
              '#markup' => join(' ', $requirement),
            ],
            'class' => 'status-info',
          ],
        ]
+1 −1
Changes for tests/src/Functional/UpgradeStatusUiTest.php: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ class UpgradeStatusUiTest extends UpgradeStatusTestBase {
      $authenticated->grantPermission('upgrade status invalid permission test');
      $authenticated->save();
      $this->drupalGet(Url::fromRoute('upgrade_status.report'));
      $this->assertSession()->pageTextContains('"upgrade status invalid permission test" of user role: "Authenticated user".');
      $this->assertSession()->pageTextContains('Permissions of user role: "Authenticated user":upgrade status invalid permission test');
    }
  }