>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3343217. --> Reported by: [tanuj.](https://www.drupal.org/user/3707941) Related to !18 !15 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Found these phpcs error</p> <pre>FILE: /update_helper/tests/src/Functional/DrushTest.php<br>----------------------------------------------------------------------------------<br>FOUND 1 ERROR AFFECTING 1 LINE<br>----------------------------------------------------------------------------------<br> 112 | ERROR | [x] Expected 1 blank line after function; 2 found<br>----------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>----------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/tests/src/Kernel/UpdaterTest.php<br>--------------------------------------------------------------------------------<br>FOUND 1 ERROR AFFECTING 1 LINE<br>--------------------------------------------------------------------------------<br> 268 | ERROR | [x] Missing function doc comment<br>--------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>--------------------------------------------------------------------------------<br><br>FILE: /update_helper/modules/update_helper_checklist/update_helper_checklist.module<br>--------------------------------------------------------------------------------------------------------------<br>FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE<br>--------------------------------------------------------------------------------------------------------------<br> 7 | WARNING | [x] 'TODO:' should match the format '@todo Fix problem X here.'<br>--------------------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>--------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/modules/update_helper_checklist/tests/modules/update_helper_checklist_test/update_helper_checklist_test.info.yml<br>--------------------------------------------------------------------------------------------------------------------------------------------------------------<br>FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE<br>--------------------------------------------------------------------------------------------------------------------------------------------------------------<br> 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically<br> 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically<br> 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically<br>--------------------------------------------------------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/modules/update_helper_checklist/tests/src/Functional/UpdateHelperChecklistToolbarTest.php<br>--------------------------------------------------------------------------------------------------------------------------------------------<br>FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES<br>--------------------------------------------------------------------------------------------------------------------------------------------<br> 22 | WARNING | [x] A comma should follow the last multiline array item. Found: 'test_page_test'<br> 43 | ERROR&nbsp;&nbsp; | [ ] The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines<br>--------------------------------------------------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>--------------------------------------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/modules/update_helper_checklist/drush.services.yml<br>--------------------------------------------------------------------------------------------------<br>FOUND 1 ERROR AFFECTING 1 LINE<br>--------------------------------------------------------------------------------------------------<br> 6 | ERROR | [x] Expected 1 newline at end of file; 3 found<br>--------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>--------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/modules/update_helper_checklist/update_helper_checklist.info.yml<br>----------------------------------------------------------------------------------------------------------------<br>FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE<br>----------------------------------------------------------------------------------------------------------------<br> 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically<br> 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically<br> 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically<br>----------------------------------------------------------------------------------------------------------------<br><br><br>FILE:/update_helper/modules/update_helper_checklist/update_helper_checklist.install<br>----------------------------------------------------------------------------------------------------------------------------------------------------<br>FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES<br>----------------------------------------------------------------------------------------------------------------------------------------------------<br> 16 | WARNING | [x] 'TODO: Improve - Get information from executed update hooks, what to mark.' should match the format '@todo Fix problem X here.'<br> 60 | ERROR&nbsp;&nbsp; | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"<br>----------------------------------------------------------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>----------------------------------------------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/modules/update_helper_checklist/src/UpdateChecklist.php<br>-------------------------------------------------------------------------------------------------------<br>FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE<br>-------------------------------------------------------------------------------------------------------<br> 14 | WARNING | [x] 'TODO: Need tests and a lot!' should match the format '@todo Fix problem X here.'<br>-------------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>-------------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/update_helper.info.yml<br>-------------------------------------------------------------------------------------------------------------<br>FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE<br>-------------------------------------------------------------------------------------------------------------<br> 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically<br> 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically<br> 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically<br>-------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/src/ReversibleConfigDiffer.php<br>--------------------------------------------------------------------------------------------------------------------------------------------<br>FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES<br>--------------------------------------------------------------------------------------------------------------------------------------------<br> 14 | WARNING | [x] 'TODO:' should match the format '@todo Fix problem X here.'<br> 44 | ERROR&nbsp;&nbsp; | [ ] The array declaration extends to column 146 (the limit is 80). The array content should be split up over multiple lines<br>--------------------------------------------------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>--------------------------------------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/src/ConfigExporter.php<br>-------------------------------------------------------------------------------------------------------------------------------------------<br>FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES<br>-------------------------------------------------------------------------------------------------------------------------------------------<br> 11 | WARNING | [x] 'TODO:' should match the format '@todo Fix problem X here.'<br> 58 | WARNING | [x] 'TODO: It would be good to log that file has been changed!!!' should match the format '@todo Fix problem X here.'<br> 73 | ERROR&nbsp;&nbsp; | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines<br>-------------------------------------------------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>-------------------------------------------------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/src/Generators/ConfigurationUpdate.php<br>--------------------------------------------------------------------------------------------------<br>FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES<br>--------------------------------------------------------------------------------------------------<br> 113 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 116 | ERROR&nbsp;&nbsp; | [x] Expected 1 space after FOREACH keyword; 0 found<br> 117 | ERROR&nbsp;&nbsp; | [x] Concat operator must be surrounded by a single space<br> 126 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br>--------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>--------------------------------------------------------------------------------------------------<br><br><br>FILE: /update_helper/src/ConfigHandler.php<br>----------------------------------------------------------------------------------------------------------------------------------------------------<br>FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE<br>----------------------------------------------------------------------------------------------------------------------------------------------------<br> 15 | WARNING | [x] 'TODO: Create UpdateDefinition class to handle configuration update entry.' should match the format '@todo Fix problem X here.'<br>----------------------------------------------------------------------------------------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>----------------------------------------------------------------------------------------------------------------------------------------------------</pre><h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>run this command in this module folder <code>phpcs --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme,css,info,txt,yml"</code></p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <h3 id="summary-ui-changes">User interface changes</h3> <h3 id="summary-api-changes">API changes</h3> <h3 id="summary-data-model-changes">Data model changes</h3>